Fix x64 cross build on arm64 macOS - #75677
Merged
janvorli merged 4 commits intoSep 21, 2022
Merged
Conversation
There were couple of minor issues that prevented successful building of x64 macOS runtime on arm64 macOS device. This change fixes them.
janvorli
added
os-mac-os-x
|
Tagging subscribers to this area: @hoyosjs Issue DetailsThere were couple of minor issues that prevented successful building of x64 macOS runtime on arm64 macOS device.
|
am11
approved these changes
Sep 15, 2022
am11
left a comment
am11
left a comment
Member
There was a problem hiding this comment.
One suggestion, otherwise LGTM. Thank you!
jkotas
reviewed
Sep 15, 2022
jkotas
reviewed
Sep 15, 2022
jkotas
approved these changes
Sep 15, 2022
Member
|
Should we merge this? |
Member
Author
|
@VSadov there were also some Linux non-mono legs timing out, I am re-running them. |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were couple of minor issues that prevented successful building of x64 macOS runtime on arm64 macOS device.
This change fixes them.
Close #74973