Reference net10.0 path for ILLink.Tasks assembly - #109619
Closed
mthalman wants to merge 1 commit into
Closed
Conversation
ghost
added
the
area-Tools-ILLink
dotnet-policy-service
Bot
added
the
linkable-framework
Contributor
|
Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas |
Member
|
Related: #109335. FYI @ViktorHofer |
sbomer
approved these changes
Nov 7, 2024
This was referenced Nov 7, 2024
Member
|
This change can't be made as is. Illink in this repo still targets net9.0. I think it would be better to avoid the TFM version in the folder path entirely. |
Member
+1 (assuming that for a given task package, there's always only a single implementation assembly). |
Member
|
For this package, yes. |
ViktorHofer
requested changes
Nov 8, 2024
ViktorHofer
left a comment
ViktorHofer
left a comment
Member
There was a problem hiding this comment.
This change can't be made because runtime still targets net9.0.
ViktorHofer
added a commit
that referenced
this pull request
Nov 8, 2024
Replaces #109619 We made a similar change recently in arcade to not use the TFM but a normalized value of the TargetFrameworkIdentifier property for tools packages.
Member
|
Submitted #109634 |
Member
Author
|
Closing in favor of #109634. |
akoeplinger
pushed a commit
that referenced
this pull request
Nov 8, 2024
Replaces #109619 We made a similar change recently in arcade to not use the TFM but a normalized value of the TargetFrameworkIdentifier property for tools packages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ILLink.Tasks targets the net10.0 TFM and it needs the assembly reference for the MSBuild props file to match that TFM.
Related to dotnet/sdk#44685