Avoid hardcoded illink.tasks TFM - #109634
Merged
Merged
Conversation
Replaces #109619 We made a similar change recently in arcade to not use the TFM but a normalized value of the TargetFrameworkIdentifier property for tools packages.
ghost
added
the
Contributor
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries |
Member
|
Nice! It'll also need am11@fd067c5. |
Member
Author
|
Oh right, we don't need that with this change anymore. Perfect :) |
akoeplinger
approved these changes
Nov 8, 2024
Member
Author
|
@am11 I tried to directly apply your patch to keep you as the committer but git didn't let me (corrupt file at L...). So I manually applied it. |
Member
|
No worries. I'm just happy to see another hardcoded platform list going away. 🙂 |
Member
Author
|
Oh damn. Locally in runtime we don't use the package layout but the build output. |
Member
|
Another piece of the puzzle: main...am11:runtime:patch-19 |
This was referenced Nov 8, 2024
akoeplinger
approved these changes
Nov 8, 2024
Member
|
/ba-g wasm failures are note related to the ILLink changes |
This was referenced Nov 8, 2024
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #109619
We made a similar change recently in arcade to not use the TFM but a normalized value of the TargetFrameworkIdentifier property for tools packages.