[wasm] Bump chrome for testing - linux: 146.0.7680.80, windows: 146.0.7680.80#125566
[wasm] Bump chrome for testing - linux: 146.0.7680.80, windows: 146.0.7680.80#125566
Conversation
|
Tagging subscribers to this area: @akoeplinger, @matouskozak, @simonrozsival |
|
#125482 contains the fix for WBT failure |
|
Retry mechanism does not work for |
The retry logic in GetChromiumDriver catches transient Chrome startup
failures and retries up to 3 times. However, the error snippet list
missed the broad 'session not created' pattern, which covers several
Chrome crash variants including:
session not created: Chrome instance exited.
session not created: Chrome failed to start: crashed.
The existing snippets ('exited abnormally', 'failed to start', etc.)
have been added reactively over time as new error messages surfaced.
Adding 'session not created' as a broader pattern covers current and
future variants of this class of transient Chrome startup failure.
Observed in dotnet/runtime#125566 (Chrome 146 bump) where 2 of 202
Helix work items failed with 'session not created: Chrome instance
exited' — the retry never fired because no snippet matched.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
🤖 Copilot Code Review — PR #125566Note This review was generated by GitHub Copilot. Holistic AssessmentMotivation: This is an automated weekly bump of the Chrome/V8 versions used for WASM browser testing on Linux, generated by the Approach: The approach is correct — a single-file change to Summary: ✅ LGTM. This is a routine, automated Chrome version bump for Linux WASM testing. The change is minimal, correctly scoped, and follows the established pattern. No new public API, no behavioral code changes, no test logic changes. Detailed Findings✅ Correctness — Version bump values are consistentThe change bumps Linux Chrome from The snapshot URL revision ( ✅ Scope — Change is correctly limitedOnly 💡 Observation — Windows versions already at same generationWindows Chrome revision (
|
No description provided.