Skip to content

[wasm] Bump chrome for testing - linux: 146.0.7680.80, windows: 146.0.7680.80#125566

Merged
lewing merged 3 commits intomainfrom
update-chrome-version-23099386357
Mar 26, 2026
Merged

[wasm] Bump chrome for testing - linux: 146.0.7680.80, windows: 146.0.7680.80#125566
lewing merged 3 commits intomainfrom
update-chrome-version-23099386357

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

No description provided.

@dotnet-policy-service
Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @akoeplinger, @matouskozak, @simonrozsival
See info in area-owners.md if you want to be subscribed.

@lewing lewing enabled auto-merge (squash) March 15, 2026 00:56
@ilonatommy
Copy link
Copy Markdown
Member

#125482 contains the fix for WBT failure session not created. In the meantime, rerunning.

@ilonatommy
Copy link
Copy Markdown
Member

ilonatommy commented Mar 23, 2026

Retry mechanism does not work for session not created: Chrome instance exited. https://github.com/dotnet/xharness/blob/b0c8bf6dba87c70e284cff06819f0cd714c8f2e4/src/Microsoft.DotNet.XHarness.CLI/Commands/WASM/Browser/WasmTestBrowserCommand.cs#L287

[10:09:46] crit: System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation.
                  ---> System.InvalidOperationException: session not created: Chrome instance exited. Examine ChromeDriver verbose log to determine the cause. (SessionNotCreated)
                    at OpenQA.Selenium.Remote.RemoteWebDriver.UnpackAndThrowOnError(Response errorResponse)
                    at OpenQA.Selenium.Remote.RemoteWebDriver.Execute(String driverCommandToExecute, Dictionary`2 parameters)
                    at OpenQA.Selenium.Remote.RemoteWebDriver.StartSession(ICapabilities desiredCapabilities)
                    at OpenQA.Selenium.Remote.RemoteWebDriver..ctor(ICommandExecutor commandExecutor, ICapabilities desiredCapabilities)
                    at OpenQA.Selenium.Chromium.ChromiumDriver..ctor(ChromiumDriverService service, ChromiumOptions options, TimeSpan commandTimeout)
                    at OpenQA.Selenium.Chrome.ChromeDriver..ctor(ChromeDriverService service, ChromeOptions options, TimeSpan commandTimeout)
                    at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Constructor(Object obj, IntPtr* args)
                    at System.Reflection.MethodBaseInvoker.InvokeDirectByRefWithFewArgs(Object obj, Span`1 copyOfArgs, BindingFlags invokeAttr)
                    --- End of inner exception stack trace ---
                    at System.Reflection.MethodBaseInvoker.InvokeDirectByRefWithFewArgs(Object obj, Span`1 copyOfArgs, BindingFlags invokeAttr)
                    at System.Reflection.MethodBaseInvoker.InvokeWithFewArgs(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
                    at System.Reflection.RuntimeConstructorInfo.Invoke(BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
                    at System.RuntimeType.CreateInstanceImpl(BindingFlags bindingAttr, Binder binder, Object[] args, CultureInfo culture)
                    at Microsoft.DotNet.XHarness.CLI.Commands.Wasm.WasmTestBrowserCommand.GetChromiumDriver[TDriverOptions,TDriver,TDriverService](String driverName, String sessionLanguage, Func`2 getDriverService, ILogger logger) in /_/src/Microsoft.DotNet.XHarness.CLI/Commands/WASM/Browser/WasmTestBrowserCommand.cs:line 316
                    at Microsoft.DotNet.XHarness.CLI.Commands.Wasm.WasmTestBrowserCommand.GetChromeDriver(String sessionLanguage, ILogger logger) in /_/src/Microsoft.DotNet.XHarness.CLI/Commands/WASM/Browser/WasmTestBrowserCommand.cs:line 190
                    at Microsoft.DotNet.XHarness.CLI.Commands.Wasm.WasmTestBrowserCommand.InvokeInternal(ILogger logger) in /_/src/Microsoft.DotNet.XHarness.CLI/Commands/WASM/Browser/WasmTestBrowserCommand.cs:line 70
                    at Microsoft.DotNet.XHarness.CLI.Commands.XHarnessCommand`1.Invoke(IEnumerable`1 arguments) in /_/src/Microsoft.DotNet.XHarness.CLI/Commands/XHarnessCommand.cs:line 145

ilonatommy added a commit to dotnet/xharness that referenced this pull request Mar 23, 2026
The retry logic in GetChromiumDriver catches transient Chrome startup
failures and retries up to 3 times. However, the error snippet list
missed the broad 'session not created' pattern, which covers several
Chrome crash variants including:

  session not created: Chrome instance exited.
  session not created: Chrome failed to start: crashed.

The existing snippets ('exited abnormally', 'failed to start', etc.)
have been added reactively over time as new error messages surfaced.
Adding 'session not created' as a broader pattern covers current and
future variants of this class of transient Chrome startup failure.

Observed in dotnet/runtime#125566 (Chrome 146 bump) where 2 of 202
Helix work items failed with 'session not created: Chrome instance
exited' — the retry never fired because no snippet matched.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor Author

🤖 Copilot Code Review — PR #125566

Note

This review was generated by GitHub Copilot.

Holistic Assessment

Motivation: This is an automated weekly bump of the Chrome/V8 versions used for WASM browser testing on Linux, generated by the bump-chrome-version.yml GitHub Actions workflow via github-actions[bot]. The automated tooling (UpdateChromeVersions MSBuild task) fetches the latest stable channel versions — keeping test infrastructure current is valuable and expected.

Approach: The approach is correct — a single-file change to eng/testing/BrowserVersions.props updating four Linux-specific properties. This is the established pattern for Chrome version bumps in this repo (same file, same automation, same workflow).

Summary: ✅ LGTM. This is a routine, automated Chrome version bump for Linux WASM testing. The change is minimal, correctly scoped, and follows the established pattern. No new public API, no behavioral code changes, no test logic changes.


Detailed Findings

✅ Correctness — Version bump values are consistent

The change bumps Linux Chrome from 145.0.7632.116146.0.7680.80, revision 15681901582197, and V8 from 14.5.20114.6.202. These are forward-moving version numbers consistent with a stable channel update.

The snapshot URL revision (1582214) differs from the Chrome revision (1582197) by 17. This is the expected pattern — the same discrepancy exists for macOS (revision 1536371 vs snapshot 1536376) and Windows (revision 1582197 vs snapshot 1582218). The snapshot build number is platform-specific and routinely differs slightly from the declared revision.

✅ Scope — Change is correctly limited

Only eng/testing/BrowserVersions.props is modified. Only Linux properties are updated (macOS and Windows remain unchanged). The automation only bumps platforms it's configured for (OSIdentifiers="linux;Windows" and OSPrefixes="Linux_x64;Win_x64" in bump-chrome-version.proj). Windows Chrome was already at the same revision (1582197) and V8 (14.6.202), suggesting a recent prior bump for Windows or a concurrent update.

💡 Observation — Windows versions already at same generation

Windows Chrome revision (1582197) and V8 (14.6.202) already match the new Linux values, which is consistent — both platforms are now aligned on Chrome 146/V8 14.6. macOS remains on an older generation (Chrome 143, V8 14.3), presumably because the automation only targets Linux and Windows (OSIdentifiers="linux;Windows").

Generated by Code Review for issue #125566 ·

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants