Skip to content

[wasm] Bump chrome for testing - linux: 146.0.7680.153, windows: 146.0.7680.81#125898

Open
github-actions[bot] wants to merge 2 commits intomainfrom
update-chrome-version-23391817758
Open

[wasm] Bump chrome for testing - linux: 146.0.7680.153, windows: 146.0.7680.81#125898
github-actions[bot] wants to merge 2 commits intomainfrom
update-chrome-version-23391817758

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

No description provided.

@dotnet-policy-service
Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @akoeplinger, @matouskozak, @simonrozsival
See info in area-owners.md if you want to be subscribed.

@ilonatommy ilonatommy enabled auto-merge (squash) March 26, 2026 10:45
@github-actions
Copy link
Copy Markdown
Contributor Author

🤖 Copilot Code Review — PR #125898

Holistic Assessment

Motivation: Automated Chrome version bump for WASM testing infrastructure. Keeps test browsers current, which is standard maintenance.

Approach: Single-property version string change in eng/testing/BrowserVersions.props — the standard mechanism for this repo.

Summary: ✅ LGTM. Trivial automated version bump — linux_ChromeVersion moves from 146.0.7680.80146.0.7680.153 (patch-level bump within the same Chrome 146 release channel). No code, API, or behavioral changes.


Detailed Findings

✅ Correctness — Version bump is well-formed

The effective diff against main is a single line change:

- <linux_ChromeVersion>146.0.7680.80</linux_ChromeVersion>
+ <linux_ChromeVersion>146.0.7680.153</linux_ChromeVersion>

The linux_ChromeRevision, linux_ChromeBaseSnapshotUrl, and linux_V8Version were already updated to the Chrome 146 values by the prior merged PR #125566, so only the patch version needs to advance here. The snapshot URL and revision are consistent.

💡 Title/Content Mismatch — Windows version not updated

The PR title states "windows: 146.0.7680.81" but the diff does not modify any Windows properties — win_ChromeVersion remains at 146.0.7680.66. This is likely just how the automated title is generated (listing latest available versions per platform), but it could be confusing for reviewers expecting a Windows bump as well. Not blocking — just an observation about the bot's title generation.

Generated by Code Review for issue #125898 ·

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant