Skip to content

JIT: Unify post-order cmp transforms into fgOptimizeRelationalComparison#127883

Merged
EgorBo merged 13 commits into
dotnet:mainfrom
BoyBaykiller:unify-cmp-transforms
May 21, 2026
Merged

JIT: Unify post-order cmp transforms into fgOptimizeRelationalComparison#127883
EgorBo merged 13 commits into
dotnet:mainfrom
BoyBaykiller:unify-cmp-transforms

Conversation

@BoyBaykiller
Copy link
Copy Markdown
Contributor

@BoyBaykiller BoyBaykiller commented May 6, 2026

Zero diffs.

@github-actions github-actions Bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label May 6, 2026
@dotnet-policy-service dotnet-policy-service Bot added the community-contribution Indicates that the PR has been added by a community member label May 6, 2026
BoyBaykiller
BoyBaykiller commented May 6, 2026
View reviewed changes
Comment thread src/coreclr/jit/morph.cpp Outdated
@dotnet-policy-service
Copy link
Copy Markdown
Contributor

dotnet-policy-service Bot commented May 6, 2026

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

This was referenced May 7, 2026
Open
Open
Closed
Open
EgorBo
EgorBo reviewed May 8, 2026
View reviewed changes
Comment thread src/coreclr/jit/morph.cpp Outdated
@BoyBaykiller
Copy link
Copy Markdown
Contributor Author

BoyBaykiller commented May 10, 2026

@EgorBo does this need any other changes? If I understood correctly "cmp" over "relop" is ok.

@BoyBaykiller BoyBaykiller changed the title JIT: Unify post-order cmp transforms intofgOptimizeCmp JIT: Unify post-order cmp transforms into fgOptimizeRelationalComparison May 11, 2026
@build-analysis build-analysis Bot mentioned this pull request May 12, 2026
Open
@BoyBaykiller BoyBaykiller mentioned this pull request May 12, 2026
Open
@BoyBaykiller BoyBaykiller requested a review from EgorBo May 14, 2026 15:02
EgorBo
EgorBo reviewed May 19, 2026
View reviewed changes
Comment thread src/coreclr/jit/morph.cpp
EgorBo
EgorBo reviewed May 19, 2026
View reviewed changes
Comment thread src/coreclr/jit/morph.cpp
EgorBo
EgorBo reviewed May 19, 2026
View reviewed changes
Comment thread src/coreclr/jit/morph.cpp Outdated
EgorBo
EgorBo reviewed May 19, 2026
View reviewed changes
Comment thread src/coreclr/jit/morph.cpp Outdated
EgorBo
EgorBo reviewed May 19, 2026
View reviewed changes
Comment thread src/coreclr/jit/morph.cpp Outdated
EgorBo
EgorBo reviewed May 19, 2026
View reviewed changes
Comment thread src/coreclr/jit/morph.cpp Outdated
@build-analysis build-analysis Bot mentioned this pull request May 19, 2026
Open
@build-analysis build-analysis Bot mentioned this pull request May 19, 2026
Open
EgorBo
EgorBo reviewed May 19, 2026
View reviewed changes
Comment thread src/coreclr/jit/morph.cpp Outdated
EgorBo
EgorBo approved these changes May 19, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@EgorBo EgorBo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one nit

EgorBo
EgorBo reviewed May 20, 2026
View reviewed changes
Comment thread src/coreclr/jit/morph.cpp Outdated
@build-analysis build-analysis Bot mentioned this pull request May 20, 2026
Open
@BoyBaykiller BoyBaykiller requested a review from EgorBo May 21, 2026 00:39
@EgorBo EgorBo enabled auto-merge (squash) May 21, 2026 01:28
@EgorBo EgorBo merged commit fdea14d into dotnet:main May 21, 2026
139 checks passed
@dotnet-maestro dotnet-maestro Bot mentioned this pull request May 21, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EgorBo EgorBo Awaiting requested review from EgorBo

Assignees

No one assigned

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@BoyBaykiller @EgorBo