Skip to content

[Eventpipe][S390X] Fix Session_Id for s390x - #129164

Merged
mdh1418 merged 3 commits into
dotnet:mainfrom
saitama951:fix_session_id
Jun 22, 2026
Merged

[Eventpipe][S390X] Fix Session_Id for s390x#129164
mdh1418 merged 3 commits into
dotnet:mainfrom
saitama951:fix_session_id

Conversation

@saitama951

Copy link
Copy Markdown
Contributor

while sending a StopTracingCommand via IPC from dotnet-gcdump, the payload consists the session_id which is not passed in the correct endian order to ep_disable which in-turn keeps the tracing going on indefinitely

while sending a StopTracingCommand the payload consists
the session_id which is not passed in the correct endian order
to ep_disable which in-turn keeps the tracing going on
indefinitely
Comment thread src/native/eventpipe/ds-eventpipe-protocol.c Outdated
Comment thread src/native/eventpipe/ds-eventpipe-protocol.c

@lateralusX lateralusX left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@mdh1418

mdh1418 commented Jun 22, 2026

Copy link
Copy Markdown
Member

/ba-g "Failure is unrelated to PR changes. The issue is #129700"

@mdh1418
mdh1418 merged commit 6735fbd into dotnet:main Jun 22, 2026
129 of 131 checks passed
@dotnet-milestone-bot dotnet-milestone-bot Bot added this to the 11.0-preview6 milestone Jun 23, 2026
@saitama951

Copy link
Copy Markdown
Contributor Author

Hi @jkotas @akoeplinger
can these 3 PR's be backported to .net 8, .net 9, .net10?
#129789
#129164
#128577

eiriktsarpalis pushed a commit that referenced this pull request Jul 15, 2026
while sending a StopTracingCommand via IPC from dotnet-gcdump, the
payload consists the session_id which is not passed in the correct
endian order to ep_disable which in-turn keeps the tracing going on
indefinitely
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants