Skip to content

[Eventpipe][S390X] Fix Session_Id for s390x #129164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mdh1418 merged 3 commits into from
Jun 22, 2026
Merged

[Eventpipe][S390X] Fix Session_Id for s390x #129164

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eb9a128
[Eventpipe][S390X] Fix Session_Id for s390x
saitama951 Jun 9, 2026
e84715a
add helper function for EventPipeStopTracingCommandPayload session_id
saitama951 Jun 19, 2026
a68c76b
change helper method and conform to other tryparse_payload methods
saitama951 Jun 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 32 additions & 2 deletions src/native/eventpipe/ds-eventpipe-protocol.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,12 @@ eventpipe_collect_tracing5_command_try_parse_payload (
uint8_t *buffer,
uint16_t buffer_len);

static
uint8_t *
eventpipe_protocol_helper_stop_tracing_try_parse_payload (
uint8_t *buffer,
uint16_t buffer_len);

static
bool
eventpipe_protocol_helper_stop_tracing (
Expand Down Expand Up @@ -854,6 +860,30 @@ eventpipe_protocol_helper_send_start_tracing_success (
return result;
}

static
uint8_t *
eventpipe_protocol_helper_stop_tracing_try_parse_payload(uint8_t *buffer, uint16_t buffer_len)
{
EP_ASSERT (buffer != NULL);

uint8_t * buffer_cursor = buffer;
uint32_t buffer_cursor_len = buffer_len;

EventPipeStopTracingCommandPayload *instance = ep_rt_object_alloc (EventPipeStopTracingCommandPayload);
ep_raise_error_if_nok (instance != NULL);

ep_raise_error_if_nok (ds_ipc_message_try_parse_uint64_t (&buffer_cursor, &buffer_cursor_len, &instance->session_id));

ep_on_exit:
ep_rt_byte_array_free (buffer);
return (uint8_t *)instance;

ep_on_error:
ds_eventpipe_stop_tracing_command_payload_free (instance);
instance = NULL;
ep_exit_error_handler ();
}

Comment thread
saitama951 marked this conversation as resolved.
static
bool
eventpipe_protocol_helper_stop_tracing (
Expand All @@ -864,7 +894,7 @@ eventpipe_protocol_helper_stop_tracing (

bool result = false;
EventPipeStopTracingCommandPayload *payload;
payload = (EventPipeStopTracingCommandPayload *)ds_ipc_message_try_parse_payload (message, NULL);
payload = (EventPipeStopTracingCommandPayload *)ds_ipc_message_try_parse_payload (message, eventpipe_protocol_helper_stop_tracing_try_parse_payload);

if (!payload) {
ds_ipc_message_send_error (stream, DS_IPC_E_BAD_ENCODING);
Expand Down Expand Up @@ -966,7 +996,7 @@ void
ds_eventpipe_stop_tracing_command_payload_free (EventPipeStopTracingCommandPayload *payload)
{
ep_return_void_if_nok (payload != NULL);
ep_rt_byte_array_free ((uint8_t *)payload);
ep_rt_object_free (payload);
}

bool
Expand Down
Loading