Enable System.Private.CoreLib for testing in CoreRun scenarios - #131493
Draft
davidwrighton wants to merge 2 commits into
Draft
Enable System.Private.CoreLib for testing in CoreRun scenarios#131493davidwrighton wants to merge 2 commits into
davidwrighton wants to merge 2 commits into
Conversation
…t infix) The wasm R2R crossgen output for System.Private.CoreLib was parked at System.Private.CoreLib.NotReadyYet.wasm so it would not be picked up as the corelib image. Emit it as System.Private.CoreLib.wasm so the crossgen'd ReadyToRun image is the one packaged and loaded. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a5c93aa6-580b-4f11-ac30-860081fab183
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts CoreCLR’s corerun and CoreLib crossgen outputs to better support browser/WASM CoreRun scenarios, particularly around resolving assemblies via the browser host probe and producing the expected CoreLib wasm artifact name.
Changes:
- In
corerun’s external assembly probe, add a browser-host probe attempt forCORE_LIBRARIES/CORE_ROOT + <assembly name>paths. - For wasm container format in
crossgen-corelib.proj, change the CoreLib wasm output name toSystem.Private.CoreLib.wasm(instead ofSystem.Private.CoreLib.NotReadyYet.wasm).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/coreclr/hosts/corerun/corerun.cpp | Adds an additional TARGET_BROWSER probe path to help resolve assemblies from browser-host registered assets. |
| src/coreclr/crossgen-corelib.proj | Updates wasm CoreLib crossgen output filename to the expected System.Private.CoreLib.wasm. |
Comment on lines
+388
to
+391
| #ifdef TARGET_BROWSER | ||
| if (BrowserHost_ExternalAssemblyProbe(full_path.c_str(), data_start, size)) | ||
| return true; | ||
| #endif // TARGET_BROWSER |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable System.Private.CoreLib for testing R2R and WASM. At least one of the suites id known to pass with this enabled. This PR is testing to see how many other failures there are.