Skip to content

Enable System.Private.CoreLib for testing in CoreRun scenarios #131493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
davidwrighton wants to merge 3 commits into
base: main
Choose a base branch
from
+5 −1
Open

Enable System.Private.CoreLib for testing in CoreRun scenarios #131493

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
560b744
Name crossgen'd wasm System.Private.CoreLib as ready (drop NotReadyYe…
davidwrighton Jul 23, 2026
d5fd1e1
Load System.Private.CoreLib (and other dlls) from CORE_ROOT as WASM i…
davidwrighton Jul 28, 2026
fa2e5de
Merge branch 'main' into spc_wasm_ryujit
AndyAyersMS Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/coreclr/crossgen-corelib.proj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
</PropertyGroup>

<PropertyGroup Condition="'$(PublishReadyToRunContainerFormat)' == 'wasm'">
<CrossgenCoreLibOutputPath>$([MSBuild]::NormalizePath('$(BinDir)', '$(CoreLibAssemblyName).NotReadyYet.wasm'))</CrossgenCoreLibOutputPath>
<CrossgenCoreLibOutputPath>$([MSBuild]::NormalizePath('$(BinDir)', '$(CoreLibAssemblyName).wasm'))</CrossgenCoreLibOutputPath>
</PropertyGroup>

<PropertyGroup Condition="'$(UseComposite)' == 'true'">
Expand Down
4 changes: 4 additions & 0 deletions src/coreclr/hosts/corerun/corerun.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,6 +385,10 @@ static bool HOST_CONTRACT_CALLTYPE external_assembly_probe(
std::string full_path = dir;
assert(full_path.back() == pal::dir_delim);
full_path.append(name);
#ifdef TARGET_BROWSER
if (BrowserHost_ExternalAssemblyProbe(full_path.c_str(), data_start, size))
return true;
#endif // TARGET_BROWSER
if (pal::try_map_file_readonly(full_path.c_str(), data_start, size))
return true;
}
Expand Down
Loading