Skip to content

Fix coreclr Test570 due to ICU on Windows feature #35435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkotas merged 4 commits into from
Apr 25, 2020
Merged

Fix coreclr Test570 due to ICU on Windows feature #35435

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ca76623
Fix coreclr Test570 due to ICU on Windows feature
safern Apr 25, 2020
3254b87
PR Feedback, remove test and add testcase to PercentDecimalDigits tests
safern Apr 25, 2020
07991e8
Fix test build
safern Apr 25, 2020
a44efb1
Actually fix the build
safern Apr 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/coreclr/tests/src/Common/CoreCLRTestLibrary/Utilities.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ public static bool Verbose
// Windows 10 October 2018 Update
public static bool IsWindows10Version1809OrGreater =>
IsWindows && GetWindowsVersion() == 10 && GetWindowsMinorVersion() == 0 && GetWindowsBuildNumber() >= 17763;

public static bool IsWindowsIoTCore
{
get
Expand Down
14 changes: 0 additions & 14 deletions src/coreclr/tests/src/Regressions/coreclr/0570/Test570.csproj
View file
Open in desktop

This file was deleted.

42 changes: 0 additions & 42 deletions src/coreclr/tests/src/Regressions/coreclr/0570/test570.cs
View file
Open in desktop

This file was deleted.

15 changes: 12 additions & 3 deletions ...aries/System.Globalization/tests/NumberFormatInfo/NumberFormatInfoPercentDecimalDigits.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,25 @@
// The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.

using System.Collections.Generic;
using Xunit;

namespace System.Globalization.Tests
{
public class NumberFormatInfoPercentDecimalDigits
{
[Fact]
public void PercentDecimalDigits_GetInvariantInfo_ReturnsExpected()
public static IEnumerable<object[]> PercentDecimalDigits_TestData()
{
yield return new object[] { NumberFormatInfo.InvariantInfo, 2, 2 };
yield return new object[] { CultureInfo.GetCultureInfo("en-US").NumberFormat, 2, 3 };
}

[Theory]
[MemberData(nameof(PercentDecimalDigits_TestData))]
public void PercentDecimalDigits_Get_ReturnsExpected(NumberFormatInfo format, int expectedNls, int expectedIcu)
{
Assert.Equal(2, NumberFormatInfo.InvariantInfo.PercentDecimalDigits);
int expected = PlatformDetection.IsNlsGlobalization ? expectedNls : expectedIcu;
Assert.Equal(expected, format.PercentDecimalDigits);
}

[Theory]
Expand Down