Disable System.IO.Tests.FileStream_SafeFileHandle.ThrowWhenHandlePositionIsChanged_async test on Browser wasm - #40920
Merged
danmoseley merged 2 commits intoAug 19, 2020
Conversation
…tionIsChanged_async test on Browser wasm
|
Tagging subscribers to this area: @safern, @ViktorHofer |
steveisok
approved these changes
Aug 17, 2020
Member
|
Do we have a sense of why it's flaky? |
Contributor
Author
Tried to find out in which conditions it could fail but I got it only once - it was during the first run on clean build. Other times I didn't manage to reproduce it. |
Contributor
Author
|
OSX/iOS lanes fail with #41006 |
Contributor
|
Merging as this is sufficiently validated and is breaking other PR validation jobs right now. |
Contributor
|
/backport to release/5.0 |
Contributor
|
Started backporting to release/5.0: https://github.com/dotnet/runtime/actions/runs/217066409 |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
System.IO.Tests.FileStream_SafeFileHandle.ThrowWhenHandlePositionIsChanged_asynctest sometimes (flaky?) fails in CI on browser wasm (according to #40886) withPlatformNotSupportedException: Cannot wait on monitors on this runtime.In this case we are used to marking the failing test with platform detection for the threading feature.
Closes #40886