[release/5.0] Ensuring that we can build online source build without genapi - #41069
Merged
Conversation
Dotnet-GitSync-Bot
added
the
area-Infrastructure-coreclr
safern
approved these changes
Aug 20, 2020
Contributor
|
Ok..required for source build success in 5.0 Btw I hope that the "github action" is not the author in git when this is merged. |
Member
GitHub will show both like in 1527834 or like in this arcade bump PR that had commits by both dotnet-maestro and Viktor: 9933a66. You'd need to do a rebase merge or standard merge rather than a squash merge if you wanted to avoid this. |
Contributor
|
@danmosemsft is this approved ? & should we do rebase & merge here ? |
Contributor
|
It seems like we are hitting this #40920 Would make sense to port this 5.0 as well |
Contributor
|
@Anipik yes sorry this is approved |
Contributor
|
Tha failure is known and already opened a pr to fix the failure |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #41064 to release/5.0
/cc @Anipik
Customer Impact
Source build can generate the tarball in a single stage.
Testing
Tested in CI
Risk
low. This change only affects source build non supported generation case