[mono] Fix LoadAssemblyRaw to not pin or copy#43830
Merged
Merged
Conversation
CoffeeFlux
requested review from
lambdageek,
thaystg and
vargaz
as code owners
|
Tagging subscribers to this area: @CoffeeFlux |
CoffeeFlux
force-pushed
the
loadassemblyraw-alloc
branch
from
04b5014 to
f0556f2
Compare
Copying of the assembly and symbols happens later, in `mono_alc_load_raw_bytes`, and the pinning is no longer necessary so long as we have the handle.
CoffeeFlux
force-pushed
the
loadassemblyraw-alloc
branch
from
f0556f2 to
087e263
Compare
lambdageek
approved these changes
Oct 26, 2020
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copying of the assembly and symbols happens later, in
mono_alc_load_raw_bytes, and the pinning is no longer necessary so long as we have the handle.Followup from #43592 (comment), cc: @lambdageek