Skip to content

[5.0] Credscan - #50120

Merged
danmoseley merged 13 commits into
dotnet:release/5.0from
aik-jahoda:jajahoda/cred-5.0
Mar 26, 2021
Merged

[5.0] Credscan #50120
danmoseley merged 13 commits into
dotnet:release/5.0from
aik-jahoda:jajahoda/cred-5.0

Conversation

@aik-jahoda

@aik-jahoda aik-jahoda commented Mar 23, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

This is port of dotnet/corefx#43051

for 6.0 - #50230

@ghost ghost added the area-System.Net label Mar 23, 2021
@ghost

ghost commented Mar 23, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

This is port of dotnet/corefx#43051

Author: aik-jahoda
Assignees: -
Labels:

area-System.Net
Milestone: -

@aik-jahoda
aik-jahoda requested a review from danmoseley March 23, 2021 20:11
@aik-jahoda
aik-jahoda marked this pull request as draft March 23, 2021 20:12
danmoseley
danmoseley approved these changes Mar 23, 2021
View reviewed changes

@danmoseley danmoseley left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check with @Anipik / @wtgodbe that we can merge asap.

@wtgodbe

wtgodbe commented Mar 23, 2021

Copy link
Copy Markdown
Member

Merging ASAP is ok, but again please make sure to cancel the triggered internal builds of release/5.0 and internal/release/5.0

danmoseley
danmoseley reviewed Mar 23, 2021
View reviewed changes
Comment thread src/libraries/System.Security.Cryptography.Xml/tests/EncryptedXmlTest.cs Outdated
@aik-jahoda aik-jahoda mentioned this pull request Mar 25, 2021
Merged
@aik-jahoda aik-jahoda mentioned this pull request Mar 25, 2021
Merged
@aik-jahoda
aik-jahoda marked this pull request as ready for review March 25, 2021 13:51
@aik-jahoda
aik-jahoda requested a review from wfurt March 25, 2021 13:52
danmoseley
danmoseley approved these changes Mar 25, 2021
View reviewed changes
Comment thread src/libraries/System.Security.Cryptography.Algorithms/tests/Rfc2898Tests.cs Outdated
danmoseley
danmoseley reviewed Mar 25, 2021
View reviewed changes
Comment thread src/libraries/System.Security.Cryptography.Algorithms/tests/Rfc2898Tests.cs Outdated
danmoseley
danmoseley reviewed Mar 25, 2021
View reviewed changes
Comment thread src/libraries/System.Security.Cryptography.Algorithms/tests/Rfc2898Tests.cs Outdated
@danmoseley

danmoseley commented Mar 26, 2021

Copy link
Copy Markdown
Contributor

System.Security.Cryptography.X509Certificates.Tests failure is the occasional sporadic OS error we get on Windows.

@danmoseley

danmoseley commented Mar 26, 2021

Copy link
Copy Markdown
Contributor

BSD run seems jammed. I'm not going to wait on that as the probability that this introduces a BSD-unique issue is vanishingly small.

@danmoseley
danmoseley merged commit aa235f8 into dotnet:release/5.0 Mar 26, 2021
@aik-jahoda
aik-jahoda deleted the jajahoda/cred-5.0 branch March 26, 2021 07:38
@runfoapp runfoapp Bot mentioned this pull request Mar 26, 2021
Open
@ghost ghost locked as resolved and limited conversation to collaborators Apr 25, 2021
@karelz karelz modified the milestones: 5.0.0, 5.0.x May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@wfurt wfurt Awaiting requested review from wfurt
1 more reviewer
@danmoseley danmoseley danmoseley approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-System.Net

Projects

None yet

Milestone

5.0.x

Development

Successfully merging this pull request may close these issues.

4 participants

@aik-jahoda @wtgodbe @danmoseley @karelz