[WIP][wasm][testing] remote loop network tests via xharness and websocket - #54289
Merged
pavelsavara merged 12 commits intoJun 22, 2021
Merged
Conversation
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsMake it possible to run
|
| Author: | pavelsavara |
|---|---|
| Assignees: | - |
| Labels: |
|
| Milestone: | - |
Member
Author
|
/azp run runtime |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsMake it possible to run
|
| Author: | pavelsavara |
|---|---|
| Assignees: | - |
| Labels: |
|
| Milestone: | - |
Member
Author
|
/azp run runtime-libraries-mono outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
7 tasks
pavelsavara
marked this pull request as ready for review
June 17, 2021 14:18
Member
Author
|
/azp run runtime-libraries-mono outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
Failed |
wfurt
approved these changes
Jun 21, 2021
wfurt
left a comment
wfurt
left a comment
Member
There was a problem hiding this comment.
Generally looks good to me.
I'm not sure I like the SocketWrapper name but I did not come up with anything better.
Long run we may add the CORS headers where needed to avoid fork for Browser.
cc: @dotnet/ncl @stephentoub for visibility.
ManickaP
approved these changes
Jun 21, 2021
ManickaP
left a comment
ManickaP
left a comment
Member
There was a problem hiding this comment.
Looks good, some minor comments, thanks.
- conditional compilation of LoopbackServer via #if TARGET_BROWSER - minimal implementation of WebSocketStream for the unit tests - simple SocketWrapper class to abstract Socket and WebSocket close/dispose/shutdown - added handlind of CORS headers and pre-flight requests as necessary - new xharness web server middleware - adding it to helix payload - better categorization of tests originally under 42852, 34690 - new active issues 54153,37669,54156,54270,54160,53876,54163
pavelsavara
force-pushed
the
pr_wasm_network_test_remote_loop
branch
from
June 21, 2021 14:56
c3bdadd to
42ad7fb
Compare
radical
reviewed
Jun 22, 2021
radical
left a comment
radical
left a comment
Member
There was a problem hiding this comment.
Just some nits, and questions. Nothing to block this over.
This was referenced Jul 28, 2021
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make it possible to run
LoopbackServertests with WASMvia moving the listening socket out of WASM process into xharness process and forwarding it via WebSockets
Contributes to #42852
xharness
tests