[wasm][http] Make content stream unseekable - #54303
Closed
lewing wants to merge 2 commits into
Closed
Conversation
ghost
added
the
|
Tagging subscribers to this area: @dotnet/ncl |
lewing
requested review from
kjpou1 and
pavelsavara
and removed request for
kjpou1
June 16, 2021 23:59
Member
|
Let's merge #54289 first, so that we could see the tests pass |
Member
|
I think arguably the test is being too strict here, and shouldn't require that the response stream be unseekable. That happens to be the case for SocketsHttpHandler here, but there's no fundamental reason it needs to be true. @geoffkizer? |
Contributor
I agree; if the resulting response Stream is seekable by default, then there's no reason to disallow this. |
Member
|
Closing in favor of #54603 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix for #54159