Delete GT_INDEX#69917
Merged
Merged
Conversation
ghost
added
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsInstead: This deletes two usages of It also deletes a case of us creating layout-less
|
SingleAccretion
force-pushed
the
Arr-Addr-Index
branch
3 times, most recently
from
35dfb9f to
2bdb2c0
Compare
Contributor
Author
|
@dotnet/jit-contrib |
am11
reviewed
May 30, 2022
Closed
SingleAccretion
force-pushed
the
Arr-Addr-Index
branch
from
65a9e57 to
ca9c61a
Compare
Contributor
|
/azp run runtime-coreclr jitstress |
|
Azure Pipelines successfully started running 1 pipeline(s). |
BruceForstall
approved these changes
Jun 7, 2022
Contributor
BruceForstall
left a comment
BruceForstall
left a comment
There was a problem hiding this comment.
This looks great. I kicked off jitstress to verify with a larger test set.
It is effectively no-CSE already because of how "optIsCSECandidate" works.
Instead: 1) For "ldelem", import "IND/OBJ(INDEX_ADDR)". 2) For "ldelema", import "INDEX_ADDR". This deletes two usages of "ADDR": 1) "OBJ(ADDR(INDEX))" from "ldelem<struct>". 2) "ADDR(INDEX)" from "ldelema".
Remove references to things that no longer exist.
Contributor
Author
|
Force-pushed to resolve a conflict with #70265. |
SingleAccretion
force-pushed
the
Arr-Addr-Index
branch
from
ca9c61a to
c7bc540
Compare
This was referenced Jun 9, 2022
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead:
1) For
ldelem, importIND/OBJ(INDEX_ADDR).2) For
ldelema, importINDEX_ADDR.This deletes two usages of
ADDR:1)
OBJ(ADDR(INDEX))fromldelem<struct>.2)
ADDR(INDEX)fromldelema.It also deletes a case of us creating layout-less
IND structnodes and some amount of auxiliary code.Diffs: a few in the tests reflecting forward substitution's limit of the amount of nodes it is willing to forward, plus one in libraries tests stemming from this code only looking at
ADDRs (fix in progress: #69961). There is also a fairly small TP regression (curiously, 64 bit-only) that has been payed for with the improvements from #69895.