Skip to content

[main] Update dependencies from dotnet/linker - #70614

Merged
vitek-karas merged 6 commits into
mainfrom
darc-main-3c3d9544-36c7-492c-b7fb-6f3dde63f4b8
Jun 22, 2022
Merged

[main] Update dependencies from dotnet/linker#70614
vitek-karas merged 6 commits into
mainfrom
darc-main-3c3d9544-36c7-492c-b7fb-6f3dde63f4b8

Conversation

@dotnet-maestro

@dotnet-maestro dotnet-maestro Bot commented Jun 11, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

This pull request updates the following dependencies

From https://github.com/dotnet/linker

  • Subscription: 0d6d6ae4-f71f-4395-53e6-08d8e409d87d
  • Build: 20220620.3
  • Date Produced: June 20, 2022 10:32:27 PM UTC
  • Commit: 17033869c8e75e3805ba42af4c5509af72c8bb72
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/dotnet/linker build 20220…
d80ecdb 
…610.2

Microsoft.NET.ILLink.Tasks
 From Version 7.0.100-1.22308.1 -> To Version 7.0.100-1.22310.2
@ghost ghost added the area-codeflow for labeling automated codeflow label Jun 11, 2022
@jkotas

jkotas commented Jun 11, 2022

Copy link
Copy Markdown
Member

All Mono llvmfullaot tests are failing. cc @marek-safar

@AaronRobinsonMSFT

AaronRobinsonMSFT commented Jun 12, 2022

Copy link
Copy Markdown
Member

@agocke Should we also run the WASM tests here?

/cc @vitek-karas

@dotnet-maestro
Update dependencies from https://github.com/dotnet/linker build 20220…
33c5a5b 
…613.4

Microsoft.NET.ILLink.Tasks
 From Version 7.0.100-1.22308.1 -> To Version 7.0.100-1.22313.4
@lewing

lewing commented Jun 14, 2022

Copy link
Copy Markdown
Member

/azp run runtime-wasm

@azure-pipelines

azure-pipelines Bot commented Jun 14, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@lewing lewing mentioned this pull request Jun 14, 2022
Closed
@dotnet-maestro
Update dependencies from https://github.com/dotnet/linker build 20220…
b5876c0 
…614.2

Microsoft.NET.ILLink.Tasks
 From Version 7.0.100-1.22308.1 -> To Version 7.0.100-1.22314.2
@jtschuster jtschuster mentioned this pull request Jun 15, 2022
Merged
@dotnet-maestro
Update dependencies from https://github.com/dotnet/linker build 20220…
ede8bf3 
…615.2

Microsoft.NET.ILLink.Tasks
 From Version 7.0.100-1.22308.1 -> To Version 7.0.100-1.22315.2
@radical

radical commented Jun 16, 2022

Copy link
Copy Markdown
Member

@agocke Should we also run the WASM tests here?

/cc @vitek-karas

For linker updates, always!

@dotnet-maestro
Update dependencies from https://github.com/dotnet/linker build 20220…
ec5b54f 
…616.2

Microsoft.NET.ILLink.Tasks
 From Version 7.0.100-1.22308.1 -> To Version 7.0.100-1.22316.2
@vitek-karas

vitek-karas commented Jun 17, 2022

Copy link
Copy Markdown
Member

There's something weird going on here. When I run this locally I do get a repro (Windows Release build Clr+Libs).
But the weird part is that it's running linker from the repo-local SDK: .dotnet\sdk\7.0.100-preview.3.22179.4\Sdks\Microsoft.NET.ILLink.Tasks\build\..\tools\net6.0\ILLink.Tasks.dll, instead of the one specified by the Versions.prop.

If I rerun the same thing with latest linker there are no warnings.

@sbomer @agocke could one of you please take a look?

Side note: Trying to repro this I also hit dotnet/linker#2845 - but that should only affect Debug builds of linker.

@sbomer sbomer mentioned this pull request Jun 17, 2022
Closed
@sbomer

sbomer commented Jun 17, 2022

Copy link
Copy Markdown
Member

it's running linker from the repo-local SDK

@vitek-karas I think dotnet/linker#2848 will fix this.

@dotnet-maestro
Update dependencies from https://github.com/dotnet/linker build 20220…
b26da97 
…620.3

Microsoft.NET.ILLink.Tasks
 From Version 7.0.100-1.22308.1 -> To Version 7.0.100-1.22320.3
@agocke

agocke commented Jun 21, 2022

Copy link
Copy Markdown
Member

/azp runtime-wasm

@azure-pipelines

azure-pipelines Bot commented Jun 21, 2022

Copy link
Copy Markdown
Command 'runtime-wasm' is not supported by Azure Pipelines.

Supported commands
  • help:
    • Get descriptions, examples and documentation about supported commands
    • Example: help "command_name"
  • list:
    • List all pipelines for this repository using a comment.
    • Example: "list"
  • run:
    • Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
    • Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
  • where:
    • Report back the Azure DevOps orgs that are related to this repository and org
    • Example: "where"

See additional documentation.

@radical

radical commented Jun 21, 2022

Copy link
Copy Markdown
Member

/azp run runtime-wasm

@azure-pipelines

azure-pipelines Bot commented Jun 21, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@vitek-karas
vitek-karas merged commit 3282677 into main Jun 22, 2022
@dotnet-maestro
dotnet-maestro Bot deleted the darc-main-3c3d9544-36c7-492c-b7fb-6f3dde63f4b8 branch June 22, 2022 07:56
@ghost ghost locked as resolved and limited conversation to collaborators Jul 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@vitek-karas vitek-karas vitek-karas approved these changes

Assignees

No one assigned

Labels

area-codeflow for labeling automated codeflow

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@jkotas @AaronRobinsonMSFT @lewing @radical @vitek-karas @sbomer @agocke