Fix package props for older SDKs - #2848
Merged
Merged
Conversation
This should keep the existing package override logic working, since the current SDK will only import the in-box ILLink.Tasks.props if this is not already set.
agocke
pushed a commit
to dotnet/runtime
that referenced
this pull request
Nov 16, 2022
This should keep the existing package override logic working, since the current SDK will only import the in-box ILLink.Tasks.props if this is not already set. Commit migrated from dotnet/linker@3f3da1d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should keep the existing package override logic working, since
the current SDK will only import the in-box ILLink.Tasks.props if
this is not already set.
We could probably remove this once runtime is updated to use an SDK
with dotnet/sdk#25993. Or, we might want to
keep it as long as any SDKs using the old override logic are still in support.
This would let them reference newer ILLink.Tasks packages as long as
the task surface doesn't contain breaking changes (like new required parameters).