improve handling of LLA in Quic - #90455
Merged
Merged
Conversation
ghost
added
the
|
Tagging subscribers to this area: @dotnet/ncl Issue Detailsnull
|
wfurt
changed the title
|
Tagging subscribers to this area: @dotnet/ncl Issue Detailsnull
|
This was referenced Aug 12, 2023
ManickaP
approved these changes
Aug 14, 2023
ManickaP
left a comment
ManickaP
left a comment
Member
There was a problem hiding this comment.
LGTM just small suggestion to a comment.
Co-authored-by: Marie Píchová <11718369+ManickaP@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some mitigation for microsoft/msquic#3813
It seems like this was always wrong and inconsistent between Linux & Windows.
I added some more tests and fix up address creation since that was easy.