Skip to content

Use symbol comparison in CustomMarshallerAttributeAnalyzer - #90850

Merged
AaronRobinsonMSFT merged 2 commits into
dotnet:mainfrom
Youssef1313:Youssef1313/symbol-comparison
Aug 19, 2023
Merged

Use symbol comparison in CustomMarshallerAttributeAnalyzer#90850
AaronRobinsonMSFT merged 2 commits into
dotnet:mainfrom
Youssef1313:Youssef1313/symbol-comparison

Conversation

@Youssef1313

@Youssef1313 Youssef1313 commented Aug 19, 2023

Copy link
Copy Markdown
Member

This is the recommended practice when writing analyzers, and it's usually more performant.

@ghost ghost added community-contribution Indicates that the PR has been added by a community member area-System.Runtime.InteropServices labels Aug 19, 2023
@ghost

ghost commented Aug 19, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: Youssef1313
Assignees: -
Labels:

area-System.Runtime.InteropServices, community-contribution

Milestone: -

@AaronRobinsonMSFT

Copy link
Copy Markdown
Member

/cc @jkoritzinsky @jtschuster

@AaronRobinsonMSFT AaronRobinsonMSFT added the source-generator Indicates an issue with a source generator feature label Aug 19, 2023
@AaronRobinsonMSFT AaronRobinsonMSFT added this to the 9.0.0 milestone Aug 19, 2023
@AaronRobinsonMSFT
AaronRobinsonMSFT merged commit ac02b66 into dotnet:main Aug 19, 2023
@Youssef1313
Youssef1313 deleted the Youssef1313/symbol-comparison branch August 19, 2023 23:27
@ghost ghost locked as resolved and limited conversation to collaborators Sep 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-System.Runtime.InteropServices community-contribution Indicates that the PR has been added by a community member source-generator Indicates an issue with a source generator feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants