Skip to content

Use symbol comparison in CustomMarshallerAttributeAnalyzer #90850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AaronRobinsonMSFT merged 2 commits into from
Aug 19, 2023
Merged

Use symbol comparison in CustomMarshallerAttributeAnalyzer #90850

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0cc5674
Use symbol comparison in `CustomMarshallerAttributeAnalyzer`
Youssef1313 Aug 19, 2023
098f667
Pass SymbolEqualityComparer
Youssef1313 Aug 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions ...InteropServices/gen/LibraryImportGenerator/Analyzers/CustomMarshallerAttributeAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -618,9 +618,9 @@ public override void Initialize(AnalysisContext context)

private void PrepareForAnalysis(CompilationStartAnalysisContext context)
{
if (context.Compilation.GetBestTypeByMetadataName(TypeNames.CustomMarshallerAttribute) is not null)
if (context.Compilation.GetBestTypeByMetadataName(TypeNames.CustomMarshallerAttribute) is { } customMarshallerAttribute)
{
var perCompilationAnalyzer = new PerCompilationAnalyzer(context.Compilation);
var perCompilationAnalyzer = new PerCompilationAnalyzer(context.Compilation, customMarshallerAttribute);
context.RegisterOperationAction(perCompilationAnalyzer.AnalyzeAttribute, OperationKind.Attribute);
}
}
Expand All @@ -630,18 +630,20 @@ private sealed partial class PerCompilationAnalyzer
private readonly Compilation _compilation;
private readonly INamedTypeSymbol _spanOfT;
private readonly INamedTypeSymbol _readOnlySpanOfT;
private readonly INamedTypeSymbol _customMarshallerAttribute;

public PerCompilationAnalyzer(Compilation compilation)
public PerCompilationAnalyzer(Compilation compilation, INamedTypeSymbol customMarshallerAttribute)
{
_compilation = compilation;
_customMarshallerAttribute = customMarshallerAttribute;
_spanOfT = compilation.GetBestTypeByMetadataName(TypeNames.System_Span_Metadata);
_readOnlySpanOfT = compilation.GetBestTypeByMetadataName(TypeNames.System_ReadOnlySpan_Metadata);
}
public void AnalyzeAttribute(OperationAnalysisContext context)
{
IAttributeOperation attr = (IAttributeOperation)context.Operation;
if (attr.Operation is IObjectCreationOperation attrCreation
&& attrCreation.Type.ToDisplayString() == TypeNames.CustomMarshallerAttribute)
&& attrCreation.Type.Equals(_customMarshallerAttribute, SymbolEqualityComparer.Default))
{
INamedTypeSymbol entryType = (INamedTypeSymbol)context.ContainingSymbol!;
IArgumentOperation? managedTypeArgument = attrCreation.GetArgumentByOrdinal(0);
Expand Down