Skip to content

Move ILLink targets to the linker repo - #25993

Merged
agocke merged 4 commits into
dotnet:mainfrom
agocke:move-illink-files
Jun 21, 2022
Merged

Move ILLink targets to the linker repo#25993
agocke merged 4 commits into
dotnet:mainfrom
agocke:move-illink-files

Conversation

@agocke

@agocke agocke commented Jun 14, 2022

Copy link
Copy Markdown
Member

This will keep the ILLink task and targets in-sync.

This will keep the ILLink task and targets in-sync.
@agocke

agocke commented Jun 14, 2022

Copy link
Copy Markdown
Member Author

I think there's some potential simplification here by getting rid of the "SDK" stuff entirely. Just <Import Include="../../Microsoft.NET.Sdk.ILLink/Microsoft.NET.Sdk.ILLink.Tasks.props" etc

@agocke

agocke commented Jun 14, 2022

Copy link
Copy Markdown
Member Author

@dsplaisted Is there any benefit to the "Sdk" login in MSBuild for these built-in components? It seems like it's just a space/time saver for people typing project files manually.

@agocke
agocke marked this pull request as draft June 15, 2022 21:26
@agocke agocke closed this Jun 15, 2022
@agocke agocke reopened this Jun 15, 2022
@agocke
agocke marked this pull request as ready for review June 21, 2022 06:54
@agocke
agocke requested a review from sbomer June 21, 2022 06:54
@agocke

agocke commented Jun 21, 2022

Copy link
Copy Markdown
Member Author

@MichalStrehovsky FYI, in case this conflicts with anything you're thinking. I was planning on extracting trimming pieces that are shared between NativeAOT and ILLink into the central publish targets (like the feature switches).

@MichalStrehovsky

Copy link
Copy Markdown
Member

@MichalStrehovsky FYI, in case this conflicts with anything you're thinking. I was planning on extracting trimming pieces that are shared between NativeAOT and ILLink into the central publish targets (like the feature switches).

Looks good to me. We should do the ILLinkTargetPath for NativeAOT targets as well. (Not really a comment for this pull request, just an observation.)

@agocke
agocke requested a review from LakshanF June 21, 2022 16:08

@LakshanF LakshanF left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the effort to keep in sync as well streamline common actions between NativeAOT and Trimming. I'm assuming that the existing tests we have for both NativeAOT and Trimming in the SDK will guard against regression here.

@agocke

agocke commented Jun 21, 2022

Copy link
Copy Markdown
Member Author

I'm assuming that the existing tests we have for both NativeAOT and Trimming in the SDK will guard against regression here.

Yup, I'm aiming for no functional change here.

@agocke
agocke merged commit 2993803 into dotnet:main Jun 21, 2022
@agocke
agocke deleted the move-illink-files branch June 21, 2022 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants