Move ILLink targets to the linker repo - #25993
Conversation
This will keep the ILLink task and targets in-sync.
|
I think there's some potential simplification here by getting rid of the "SDK" stuff entirely. Just |
|
@dsplaisted Is there any benefit to the "Sdk" login in MSBuild for these built-in components? It seems like it's just a space/time saver for people typing project files manually. |
|
@MichalStrehovsky FYI, in case this conflicts with anything you're thinking. I was planning on extracting trimming pieces that are shared between NativeAOT and ILLink into the central publish targets (like the feature switches). |
Looks good to me. We should do the ILLinkTargetPath for NativeAOT targets as well. (Not really a comment for this pull request, just an observation.) |
LakshanF
left a comment
There was a problem hiding this comment.
I like the effort to keep in sync as well streamline common actions between NativeAOT and Trimming. I'm assuming that the existing tests we have for both NativeAOT and Trimming in the SDK will guard against regression here.
Yup, I'm aiming for no functional change here. |
This will keep the ILLink task and targets in-sync.