Implemented shorthand syntax for ColumnDefinitions and RowDefinitions#10317
Closed
himgoyalmicro wants to merge 14 commits into
Closed
Implemented shorthand syntax for ColumnDefinitions and RowDefinitions#10317himgoyalmicro wants to merge 14 commits into
himgoyalmicro wants to merge 14 commits into
Conversation
dotnet-policy-service
Bot
requested review from
Kuldeep-MS,
dipeshmsft and
singhashish-wpf
dotnet-policy-service
Bot
added
the
PR
h3xds1nz
reviewed
Jan 20, 2025
Member
h3xds1nz
left a comment
h3xds1nz
left a comment
There was a problem hiding this comment.
I went through this rather quickly, I believe it was otherwise tested and nothing seems to strike me as wrong besides the repeating null-checks in the same method, so just adding my nits/code-style pretty much.
Comments apply always to both collections as they're the same.
| } | ||
| set | ||
| { | ||
| if (value?.Owner == this) |
Member
There was a problem hiding this comment.
I'd probably put the whole setter into a method; however the main thing is I'd refactor the triple null check in this procedure, you should only need to check for whether value is null once here.
h3xds1nz
reviewed
Jan 20, 2025
miloush
reviewed
Feb 11, 2025
|
Please update description to give overview on the older format as well |
…micro/wpf into GridShorthandXamlSyntax
…himgoyalmicro/wpf into GridShorthandXamlSyntax" This reverts commit 3d1af27, reversing changes made to c7f0b8f.
Contributor
Author
|
Closing in favor of #10866 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #9802
Description
It will simplify the definition syntax of RowDefinitions and ColumnDefinitions by:
Decoupled RowDefinitionCollection and ColumnDefinitionCollection from the owner grid to ensure VS Hot Reload functionality remains intact.
Customer Impact
This feature will make Grid markup less verbose, allowing developers to create grids with simpler syntax.
Regression
N/A
Testing
Local build pass
Risk
Low
Microsoft Reviewers: Open in CodeFlow