Implemented shorthand syntax for ColumnDefinitions and RowDefinitions#9956
Closed
himgoyalmicro wants to merge 3 commits into
Closed
Implemented shorthand syntax for ColumnDefinitions and RowDefinitions#9956himgoyalmicro wants to merge 3 commits into
himgoyalmicro wants to merge 3 commits into
Conversation
Member
|
Great to see this going forward! Before checking the actual code, I'd have two things:
|
h3xds1nz
reviewed
Oct 15, 2024
h3xds1nz
reviewed
Oct 16, 2024
Member
|
@himgoyalmicro The changes look good to me now, I've left two more comments, along with the unresolved ones that's I think all from my side. Thank you. |
Member
|
One question; did the Speaking of the setter, this is just a massive nitpick, but I believe the properties could be unifified in style as just: _data ??= new ExtendedData();
_data.ColumnDefinitions = value ?? new ColumnDefinitionCollection(this);And the getters then could be the same: _data ??= new ExtendedData();
_data.ColumnDefinitions ??= new ColumnDefinitionCollection(this);
return _data.ColumnDefinitions; |
Member
|
It would be also good to add this, so you don't have to solo-close the issues after this would be eventually merged. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #9802
Description
It will simplify the definition syntax of RowDefinitions and ColumnDefinitions by:
Customer Impact
This feature will make Grid markup less verbose, allowing developers to create grids with simpler syntax.
Regression
N/A
Testing
Risk
Microsoft Reviewers: Open in CodeFlow