Sync MilCodeGen to generated code#10430
Conversation
Contributes to dotnet#10429
|
As per IDE0073 we do not have to include the third line of the header as in Style.cs , EmptyFileHelper.cs generators. But you included it here, is it reduce the diff in generation and will be handled by other MilCodeGen PRs ? |
Yes, I went with what most files used to reduce the diff and removing the third line of the header could be done in a followup PR. |
|
I can just resync my PR afterwards. |
|
@dipeshmsft Thanks for the review, I pushed a commit that reintroduces the commented assert. I won't rebase my other PRs onto this PR just for that since it's a minor change that doesn't affect the generated code. |
|
Thanks @ThomasGoulet73 for this contribution. I will move ahead to other PRs now. |
|
Thanks @dipeshmsft, I'll rebase my other PRs. |
Contributes to #10429
Description
Syncs MilCodeGen to the generated code. This makes it as close as possible to reduce the diff and include changes that were made in the generated code.
Customer Impact
None, this does not affect shipping code.
Regression
No.
Testing
Local build + CI + I manually validated the generated code.
Risk
Now to none, this does not affect shipping code.
Microsoft Reviewers: Open in CodeFlow