Run MilCodeGen for PresentationCore

[ThomasGoulet73]

Contributes to #10429

Description

Generates the code in PresentationCore using the changes from #10430.

I recommend reviewing only the last commit and with whitespace changes hidden, use this link.

Customer Impact

None, shouldn't affect customers.

Regression

No.

Testing

Local build + CI + I manually validated the generated code.

Risk

Low, there shouldn't be any functional changes.

Microsoft Reviewers: Open in CodeFlow

[ThomasGoulet73]

This PR is blocked by #10430.

[dipeshmsft]

LGTM. No doubt there are spacing issues and in TextDecorationCollection we have [index] converted to [ index ], but I guess it should be handled in a separate PR.

@ThomasGoulet73 are you planning to work on the spacing and other issue ?

[h3xds1nz]

That is to reduce the diff. TextDecorationCollection is like one of the few that got re-formatted because most of them are actually as [ index ].

[dipeshmsft]

TextDecorationCollection is like one of the few that got re-formatted because most of them are actually as [ index ].

I thought this was reverted back to this state because of the limitation of the generator. This code gets generated from this place :

wpf/src/Microsoft.DotNet.Wpf/src/WpfGfx/codegen/mcg/helpers/CollectionHelper.cs

Line 192 in 5f713e2

[[type]] oldValue = _collection[ [[index]] ];

and if we remove the spaces, the generator crashes throwing a syntax error.

[h3xds1nz]

Eitherway is possible tbh, I know where its coming from but I didn't try to modify it.

[ThomasGoulet73]

I did hit the bracket limitation but the main reason I reverted TextDecorationCollection instead of fixing the code generator was because, as @h3xds1nz said, it was the only 1 of many files generated from a template that was formatted manually so either I reverted this file or changed a bunch of other files and I chose the option with the smaller diff.

and if we remove the spaces, the generator crashes throwing a syntax error.

I hit this problem also but there's way to workaround this limitation, you just need to concat the string with the [ and ] in a variable instead of inline and it will fix the parser error.

I do plan on working on formatting the generated code in the future.