Remove FriendAccessAllowedAttribute usage#6561
Merged
Merged
Conversation
ghost
assigned
ghost
requested review from
ThomasGoulet73
force-pushed
the
remove-friendaccessallowed
branch
from
0050fd8 to
81f5414
Compare
ThomasGoulet73
force-pushed
the
remove-friendaccessallowed
branch
from
112f7b1 to
dcf536e
Compare
Contributor
Author
|
I rebased to fix the conflicts. |
Contributor
|
Thanks @ThomasGoulet73! We'll consider this PR for our upcoming CTPs. |
ThomasGoulet73
force-pushed
the
remove-friendaccessallowed
branch
from
dcf536e to
1971677
Compare
Contributor
Author
|
I rebased to fix the conflicts. |
Member
Now, this branch has conflicts |
ThomasGoulet73
force-pushed
the
remove-friendaccessallowed
branch
from
1971677 to
4228c81
Compare
Contributor
Author
|
I rebased to fix the conflicts. Thanks for the ping @lindexi. |
Member
|
dotnet/runtime#10707 has some more details on this attribute. |
JeremyKuhne
approved these changes
Oct 2, 2024
Member
JeremyKuhne
left a comment
JeremyKuhne
left a comment
There was a problem hiding this comment.
@pchaurasia14 This would be good to get in.
JeremyKuhne
added a commit
to JeremyKuhne/wpf
that referenced
this pull request
Oct 3, 2024
These are CAS holdovers from .NET Framework that add unnecessary complexity. Uses more modern / safer syntax where I've modified code. I've also removed a few asserts where they then fall over on the next line anyway. Similar to and should follow dotnet#7161 and dotnet#6561
dipeshmsft
approved these changes
Oct 4, 2024
Member
|
Awesome! Those replacements from Thomas will clear out so much clutter. |
JeremyKuhne
added a commit
to JeremyKuhne/wpf
that referenced
this pull request
Oct 4, 2024
These are CAS holdovers from .NET Framework that add unnecessary complexity. Uses more modern / safer syntax where I've modified code. I've also removed a few asserts where they then fall over on the next line anyway. Similar to and should follow dotnet#7161 and dotnet#6561
dipeshmsft
pushed a commit
that referenced
this pull request
Oct 7, 2024
* Remove SecurityCriticalData/Class These are CAS holdovers from .NET Framework that add unnecessary complexity. Uses more modern / safer syntax where I've modified code. I've also removed a few asserts where they then fall over on the next line anyway. Similar to and should follow #7161 and #6561 * Address feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove FriendAccessAllowedAttribute usage since it is not enforced in .Net Core. FriendAccessAllowedAttribute is an undocumented and non-public attribute which is not supported anymore. To use
FriendAccessAllowedAttribute, when supported, you need to set InternalsVisibleToAttribute.AllInternalsVisible to false, which is never set in this repo.There are modifications to generated files in
src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/Generatedbut these files are generated from Elements.cs which is not runnable in this repo right now (#6135) but it should be fine because once we can run MilCodeGen, there shouldn't be any diffs.Customer Impact
None.
Regression
No.
Testing
Local build + CI.
Risk
Low.
Microsoft Reviewers: Open in CodeFlow