Remove SecurityCriticalData/Class#9882
Merged
Merged
Conversation
dotnet-policy-service
Bot
requested review from
dipeshmsft and
singhashish-wpf
dotnet-policy-service
Bot
added
the
PR
lonitra
reviewed
Oct 4, 2024
Member
lonitra
left a comment
lonitra
left a comment
There was a problem hiding this comment.
Mainly minor style comments. Otherwise LGTM 👍
Member
Author
|
@dipeshmsft: @lonitra's suggestions are nits that I'll take care of in the other PR's I'm working on if we don't find anything logically wrong that requires an update here. |
These are CAS holdovers from .NET Framework that add unnecessary complexity. Uses more modern / safer syntax where I've modified code. I've also removed a few asserts where they then fall over on the next line anyway. Similar to and should follow dotnet#7161 and dotnet#6561
JeremyKuhne
force-pushed
the
removeseccrit
branch
from
c267c07 to
50810e5
Compare
Member
Author
|
Rebased and addressed feedback |
dipeshmsft
approved these changes
Oct 7, 2024
Member
|
@JeremyKuhne , reviewed the PR. All looks good, some style changes needed here and there, but that are probably fine. Going ahead with the merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are CAS holdovers from .NET Framework that add unnecessary complexity. (They are making it more difficult for me to do interop work.)
Uses more modern / safer syntax where I've modified code. I've also removed a few asserts where they then fall over on the next line anyway.
Similar to and should follow #7161 and #6561
Microsoft Reviewers: Open in CodeFlow