Skip to content

feat: Reassign 12 Ethiopia cities to Sidama (SI) and Southwest Ethiopia Peoples (SW) states#1154

Merged
dr5hn merged 3 commits intomasterfrom
copilot/update-ethiopia-state-data
Oct 15, 2025
Merged

feat: Reassign 12 Ethiopia cities to Sidama (SI) and Southwest Ethiopia Peoples (SW) states#1154
dr5hn merged 3 commits intomasterfrom
copilot/update-ethiopia-state-data

Conversation

Copy link
Contributor

Copilot AI commented Oct 14, 2025

Ethiopia Cities Reassignment to New States

Based on issue #1152 and the previous fix that added Sidama (SI) and Southwest Ethiopia Peoples (SW) states, we completed the reassignment of cities from Southern Nations, Nationalities and Peoples (SN) to the correct new states.

Progress:

  • Analyze current city distribution in Ethiopia
  • Identify cities that belong to Sidama (SI) - state_id 5465
  • Identify cities that belong to Southwest Ethiopia Peoples (SW) - state_id 5466
  • Update cities to use correct state_code SI (7 cities)
  • Update cities to use correct state_id 5465 for SI
  • Update cities to use correct state_code SW (5 cities)
  • Update cities to use correct state_id 5466 for SW
  • Validate the changes
  • Document the changes
  • Update copilot-instructions.md with note about single markdown file per Issue/PR

Summary of Changes:

Cities Reassigned to Sidama (SI, state_id: 5465):

  1. Hawassa (capital) - ID 38651 ✅
  2. Dīla - ID 38625 ✅
  3. Hāgere Selam - ID 38655 ✅
  4. Yirga 'Alem - ID 38719 ✅
  5. Wendo - ID 38710 ✅
  6. Leku - ID 38672 ✅
  7. Sidama Zone - ID 38698 ✅

Cities Reassigned to Southwest Ethiopia Peoples (SW, state_id: 5466):

  1. Bonga (capital) - ID 38607 ✅
  2. Mīzan Teferī - ID 38683 ✅
  3. Tippi - ID 38705 ✅
  4. Bench Maji Zone - ID 38603 ✅
  5. Sheka Zone - ID 38696 ✅

Validation Results:

  • ✅ Total cities: 144 (unchanged)
  • ✅ Sidama (SI) cities: 7
  • ✅ Southwest (SW) cities: 5
  • ✅ Southern Nations (SN) cities: 21 (reduced from 33)
  • ✅ All 13 Ethiopian states now have cities assigned
  • ✅ JSON syntax validated

Documentation:

  • Created .github/fixes-docs/ETHIOPIA_CITIES_REASSIGNMENT.md with full details
  • Updated .github/fixes-docs/ETHIOPIA_SUMMARY.md with completion status
  • Updated .github/copilot-instructions.md to clarify documentation guidelines
Original prompt

This section details on the original issue you should resolve

<issue_title>[Data]: Ethiopia state missing</issue_title>
<issue_description>### What needs correction?

State/Province

Entity Name

na

Parent Entity

Ethiopia

Which field needs correction?

Other

Current (Incorrect) Value

na

Correct Value

na

Source URL

https://www.iso.org/obp/ui#iso:code:3166:ET

Additional Notes

Ethiopia missing states and there missing cities.

in ISO have 11 regional states & 2 administration

Type Code Name
Administration ET-AA* Addis Ababa
Regional State ET-AF* Afar
Regional State ET-AM* Amara
Regional State ET-BE* Benshangul-Gumaz
Administration ET-DD* Dire Dawa
Regional State ET-GA* Gambela Peoples
Regional State ET-HA* Harari People
Regional State ET-OR* Oromia
Regional State ET-SI* Sidama
Regional State ET-SO* Somali
Regional State ET-SN* Southern Nations, Nationalities and Peoples
Regional State ET-SW* Southwest Ethiopia Peoples
Regional State ET-TI* Tigrai

In database have only 9 states & 2 administration .

add missing 2 regional states and there missing cities.

https://en.wikipedia.org/wiki/Regions_of_Ethiopia

https://en.wikipedia.org/wiki/Sidama_Region

https://en.wikipedia.org/wiki/South_West_Ethiopia_Peoples%27_Region</issue_description>

<agent_instructions>The states are in place now we need to work on checking the cities are in place for all states in ethiopia check #1152 for more details and there is docs in .github/fixes-docs available for what fixes done in last PR.</agent_instructions>

Comments on the Issue (you are @copilot in this section)

Fixes #1151


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

…tates

Co-authored-by: dr5hn <6929121+dr5hn@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix missing states and cities for Ethiopia feat: Reassign 12 Ethiopia cities to Sidama (SI) and Southwest Ethiopia Peoples (SW) states Oct 14, 2025
Copilot AI requested a review from dr5hn October 14, 2025 16:09
@dr5hn
Copy link
Owner

dr5hn commented Oct 15, 2025

@copilot Can you please make a note of only one markdown file should be created for one Issue/PR within .github/fixes-docs. Add this note to copilot-instructions

…fixes-docs

Co-authored-by: dr5hn <6929121+dr5hn@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Oct 15, 2025

@copilot Can you please make a note of only one markdown file should be created for one Issue/PR within .github/fixes-docs. Add this note to copilot-instructions

Added note to .github/copilot-instructions.md specifying that only one markdown file should be created per Issue/PR in .github/fixes-docs/. The updated section now clearly states to create only ONE markdown file per Issue/PR and includes a warning not to create multiple separate files for the same issue/PR. (commit: short hash will be in next message)

@copilot Can you please make a note of only one markdown file should be created for one Issue/PR within .github/fixes-docs. Add this note to copilot-instructions

Added note to .github/copilot-instructions.md specifying that only one markdown file should be created per Issue/PR in .github/fixes-docs/. The updated section now clearly states to create only ONE markdown file per Issue/PR and includes a warning not to create multiple separate files for the same issue/PR. (88fb648)

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 15, 2025
@dr5hn dr5hn marked this pull request as ready for review October 15, 2025 05:40
@dr5hn dr5hn merged commit 1c77a4d into master Oct 15, 2025
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Oct 15, 2025
@dr5hn dr5hn deleted the copilot/update-ethiopia-state-data branch October 15, 2025 05:41
@dosubot dosubot bot added the fixed Issue has been fixed label Oct 15, 2025
Copilot AI added a commit that referenced this pull request Oct 15, 2025
…ia Peoples (SW) states (#1154)

* Initial plan

* feat: Reassign 12 Ethiopia cities to Sidama (SI) and Southwest (SW) states

Co-authored-by: dr5hn <6929121+dr5hn@users.noreply.github.com>

* docs: Add note about creating only one markdown file per Issue/PR in fixes-docs

Co-authored-by: dr5hn <6929121+dr5hn@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: dr5hn <6929121+dr5hn@users.noreply.github.com>
dr5hn added a commit that referenced this pull request Oct 15, 2025
…sions (#1156)

* Initial plan

* Add missing Ad Dali' governorate (YE-DA) to Yemen

Co-authored-by: dr5hn <6929121+dr5hn@users.noreply.github.com>

* feat: Reassign 12 Ethiopia cities to Sidama (SI) and Southwest Ethiopia Peoples (SW) states (#1154)

* Initial plan

* feat: Reassign 12 Ethiopia cities to Sidama (SI) and Southwest (SW) states

Co-authored-by: dr5hn <6929121+dr5hn@users.noreply.github.com>

* docs: Add note about creating only one markdown file per Issue/PR in fixes-docs

Co-authored-by: dr5hn <6929121+dr5hn@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: dr5hn <6929121+dr5hn@users.noreply.github.com>

* Initial plan

* docs: Consolidate Yemen documentation into single file per updated guidelines

Co-authored-by: dr5hn <6929121+dr5hn@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: dr5hn <6929121+dr5hn@users.noreply.github.com>
@dosubot dosubot bot mentioned this pull request Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fixed Issue has been fixed lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Data]: Ethiopia state missing

2 participants