Skip to content

Add missing Ad Dali' governorate (YE-DA) to Yemen administrative divisions#1156

Merged
dr5hn merged 5 commits intomasterfrom
copilot/add-missing-yemen-governorates
Oct 15, 2025
Merged

Add missing Ad Dali' governorate (YE-DA) to Yemen administrative divisions#1156
dr5hn merged 5 commits intomasterfrom
copilot/add-missing-yemen-governorates

Conversation

Copy link
Contributor

Copilot AI commented Oct 15, 2025

  • Analyze current Yemen governorate data (21 states found, 1 missing)
  • Identify missing governorate: Ad Dali' (YE-DA)
  • Review state structure and required fields
  • Gather accurate data for Ad Dali' governorate from official sources
  • Add Ad Dali' governorate to contributions/states/states.json
  • Validate JSON structure (✅ Valid)
  • Verify all 22 ISO codes present (✅ Complete)
  • Verify correct distribution (✅ 21 governorates + 1 municipality)
  • Rebase on latest master branch
  • Update documentation to follow new guidelines (single file per issue)
  • Complete fix verification
Original prompt

This section details on the original issue you should resolve

<issue_title>[Data]: Yemen governorate missing</issue_title>
<issue_description>### What needs correction?

State/Province

Entity Name

na

Parent Entity

Yemen

Which field needs correction?

Other

Current (Incorrect) Value

na

Correct Value

na

Source URL

https://www.iso.org/obp/ui#iso:code:3166:YE

Additional Notes

Yemen missing governorate and there missing cities. In ISO have 21 governorate & 1 municipality.

Type | Code | Name
-- | -- | -- | --
Governorate | YE-AB* | Abyan
Governorate | YE-BA* | Al Bayda
Governorate | YE-JA* | Al Jawf
Governorate | YE-MR* | Al Mahrah
Governorate | YE-MW* | Al Mahwit
Governorate | YE-HU* | Al Hudaydah
Municipality | YE-SA* | Amanat al Asimah
Governorate | YE-SU* | Arkhabil Suqutra
Governorate | YE-DA* | Ad Dali'
Governorate | YE-DH* | Dhamar
Governorate | YE-IB* | Ibb
Governorate | YE-LA* | Lahij
Governorate | YE-MA* | Ma'rib
Governorate | YE-RA* | Raymah
Governorate | YE-SH* | Shabwah
Governorate | YE-TA* | Ta'izz
Governorate | YE-SN* | Sana'a
Governorate | YE-SD* | Sa'dah
Governorate | YE-HJ* | Hajjah
Governorate | YE-HD* | Hadramawt
Governorate | YE-AD* | Aden
Governorate | YE-AM* | Amran

In database have only 20 governorate & 1 municipality.

add missing 1 governorate and there missing cities.

https://en.wikipedia.org/wiki/Governorates_of_Yemen

https://en.wikipedia.org/wiki/Dhale_Governorate</issue_description>

Comments on the Issue (you are @copilot in this section)

Fixes #1155


💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

Co-authored-by: dr5hn <6929121+dr5hn@users.noreply.github.com>
Copilot AI changed the title [WIP] Add missing governorates for Yemen Add missing Ad Dali' governorate (YE-DA) to Yemen administrative divisions Oct 15, 2025
Copilot AI requested a review from dr5hn October 15, 2025 04:37
@dr5hn
Copy link
Owner

dr5hn commented Oct 15, 2025

@copilot please rebase/merge updates from master branch and re check the copilot instructions and adjust your changes.

Copilot AI and others added 3 commits October 15, 2025 05:47
…ia Peoples (SW) states (#1154)

* Initial plan

* feat: Reassign 12 Ethiopia cities to Sidama (SI) and Southwest (SW) states

Co-authored-by: dr5hn <6929121+dr5hn@users.noreply.github.com>

* docs: Add note about creating only one markdown file per Issue/PR in fixes-docs

Co-authored-by: dr5hn <6929121+dr5hn@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: dr5hn <6929121+dr5hn@users.noreply.github.com>
…idelines

Co-authored-by: dr5hn <6929121+dr5hn@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Oct 15, 2025

@copilot please rebase/merge updates from master branch and re check the copilot instructions and adjust your changes.

Done! Rebased on latest master (commit 1c77a4d) and updated documentation to follow the new guidelines - consolidated two separate markdown files into a single FIX_1155_SUMMARY.md file. Changes in commit e3bf64d.

@dr5hn dr5hn marked this pull request as ready for review October 15, 2025 06:25
@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Oct 15, 2025
@dr5hn dr5hn merged commit b9575e1 into master Oct 15, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 15, 2025
@dr5hn dr5hn deleted the copilot/add-missing-yemen-governorates branch October 15, 2025 06:26
@dosubot dosubot bot added the missing-records Missing some records label Oct 15, 2025
@dosubot dosubot bot mentioned this pull request Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer missing-records Missing some records size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Data]: Yemen governorate missing

2 participants