Skip to content

Fix Yemen cities data: correct timezones, remove duplicates, and complete state coverage#1165

Merged
dr5hn merged 2 commits intomasterfrom
copilot/add-missing-governorate-yemen
Oct 16, 2025
Merged

Fix Yemen cities data: correct timezones, remove duplicates, and complete state coverage#1165
dr5hn merged 2 commits intomasterfrom
copilot/add-missing-governorate-yemen

Conversation

Copy link
Contributor

Copilot AI commented Oct 15, 2025

Following the addition of the missing Ad Dali' governorate in PR #1156, this PR addresses critical data quality issues discovered in Yemen's cities dataset during comprehensive review.

Issues Fixed

1. Incorrect Timezone (All 339 Cities)

Problem: Every city in Yemen had timezone "Europe/Moscow" instead of the correct "Asia/Aden".

Impact: All 339 cities now use the correct IANA timezone for Yemen (Asia/Aden, UTC+3).

2. Duplicate City Entry

Problem: "Az Zahir" (الظاهر) appeared twice with conflicting data:

  • ID 130803 in Al Jawf (JA) at coordinates 16.33°N, 44.52°E
  • ID 130804 in Al Bayda' (BA) at coordinates 13.99°N, 45.42°E
  • Both entries shared WikiData ID Q20423895

Resolution: Research confirmed WikiData Q20423895 refers to Az Zahir district in Al Bayda' Governorate. Removed the incorrect duplicate (ID 130803) and kept the accurate entry (ID 130804).

3. Sanaa City Misassignment

Problem: Sanaa (صنعاء), Yemen's capital city, was assigned to Sana'a Governorate (YE-SN, state_id: 1236) instead of the capital municipality.

Correction: Reassigned Sanaa (ID 130964) to Amanat Al Asimah municipality (YE-SA, state_id: 1232). This aligns with WikiData Q2471 and the administrative structure where Amanat Al Asimah is the special capital municipality containing Sanaa city, similar to Washington D.C. or Brasília.

4. Missing Cities for New Governorate

Problem: The newly added Ad Dali' governorate (YE-DA, state_id: 5467 from PR #1156) had no cities assigned.

Addition: Added Ad Dali' city (الضالع) as the governorate's capital with WikiData Q7308711.

Results

Metric Before After
Total Cities 339 339
Correct Timezone 0 339 ✅
Duplicate Cities 1 pair 0 ✅
States with Cities 20/22 22/22 ✅
Amanat Al Asimah Cities 0 1 ✅
Ad Dali' Cities 0 1 ✅

Validation

  • ✅ JSON structure validated
  • ✅ All required fields present (name, state_id, state_code, country_id, country_code, latitude, longitude)
  • ✅ No duplicate city names
  • ✅ All 22 governorates/municipalities have city representation
  • ✅ All timezones correct (Asia/Aden)
  • ✅ WikiData IDs verified against official sources

Files Changed

  • contributions/cities/YE.json - Yemen cities cleaned and corrected (339 cities)
  • .github/fixes-docs/YEMEN_CITIES_CLEANUP.md - Comprehensive documentation

References

Fixes #1155

Original prompt

This section details on the original issue you should resolve

<issue_title>[Data]: Yemen governorate missing</issue_title>
<issue_description>### What needs correction?

State/Province

Entity Name

na

Parent Entity

Yemen

Which field needs correction?

Other

Current (Incorrect) Value

na

Correct Value

na

Source URL

https://www.iso.org/obp/ui#iso:code:3166:YE

Additional Notes

Yemen missing governorate and there missing cities. In ISO have 21 governorate & 1 municipality.

Type | Code | Name
-- | -- | -- | --
Governorate | YE-AB* | Abyan
Governorate | YE-BA* | Al Bayda
Governorate | YE-JA* | Al Jawf
Governorate | YE-MR* | Al Mahrah
Governorate | YE-MW* | Al Mahwit
Governorate | YE-HU* | Al Hudaydah
Municipality | YE-SA* | Amanat al Asimah
Governorate | YE-SU* | Arkhabil Suqutra
Governorate | YE-DA* | Ad Dali'
Governorate | YE-DH* | Dhamar
Governorate | YE-IB* | Ibb
Governorate | YE-LA* | Lahij
Governorate | YE-MA* | Ma'rib
Governorate | YE-RA* | Raymah
Governorate | YE-SH* | Shabwah
Governorate | YE-TA* | Ta'izz
Governorate | YE-SN* | Sana'a
Governorate | YE-SD* | Sa'dah
Governorate | YE-HJ* | Hajjah
Governorate | YE-HD* | Hadramawt
Governorate | YE-AD* | Aden
Governorate | YE-AM* | Amran

In database have only 20 governorate & 1 municipality.

add missing 1 governorate and there missing cities.

https://en.wikipedia.org/wiki/Governorates_of_Yemen

https://en.wikipedia.org/wiki/Dhale_Governorate</issue_description>

<agent_instructions>We've added missing states, but i want you to check states and cities of Yemen and add missing ones and see if there's any duplicates remove it. if it's not suitable to stay in cities remove them.

Check #1156 PR and .github/fixes-docs for more details on this issue</agent_instructions>

Comments on the Issue (you are @copilot in this section)

Fixes #1155


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: dr5hn <6929121+dr5hn@users.noreply.github.com>
Copilot AI changed the title [WIP] Add missing governorate for Yemen Fix Yemen cities data: correct timezones, remove duplicates, and complete state coverage Oct 15, 2025
Copilot AI requested a review from dr5hn October 15, 2025 06:56
@dr5hn dr5hn marked this pull request as ready for review October 16, 2025 05:26
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Oct 16, 2025
@dr5hn dr5hn merged commit 52f5144 into master Oct 16, 2025
@dr5hn dr5hn deleted the copilot/add-missing-governorate-yemen branch October 16, 2025 05:27
@dosubot dosubot bot added the fixed Issue has been fixed label Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fixed Issue has been fixed size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Data]: Yemen governorate missing

2 participants