Conversation
Co-authored-by: dr5hn <6929121+dr5hn@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add missing governorate for Yemen
Fix Yemen cities data: correct timezones, remove duplicates, and complete state coverage
Oct 15, 2025
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the addition of the missing Ad Dali' governorate in PR #1156, this PR addresses critical data quality issues discovered in Yemen's cities dataset during comprehensive review.
Issues Fixed
1. Incorrect Timezone (All 339 Cities)
Problem: Every city in Yemen had timezone
"Europe/Moscow"instead of the correct"Asia/Aden".Impact: All 339 cities now use the correct IANA timezone for Yemen (Asia/Aden, UTC+3).
2. Duplicate City Entry
Problem: "Az Zahir" (الظاهر) appeared twice with conflicting data:
Resolution: Research confirmed WikiData Q20423895 refers to Az Zahir district in Al Bayda' Governorate. Removed the incorrect duplicate (ID 130803) and kept the accurate entry (ID 130804).
3. Sanaa City Misassignment
Problem: Sanaa (صنعاء), Yemen's capital city, was assigned to Sana'a Governorate (YE-SN, state_id: 1236) instead of the capital municipality.
Correction: Reassigned Sanaa (ID 130964) to Amanat Al Asimah municipality (YE-SA, state_id: 1232). This aligns with WikiData Q2471 and the administrative structure where Amanat Al Asimah is the special capital municipality containing Sanaa city, similar to Washington D.C. or Brasília.
4. Missing Cities for New Governorate
Problem: The newly added Ad Dali' governorate (YE-DA, state_id: 5467 from PR #1156) had no cities assigned.
Addition: Added Ad Dali' city (الضالع) as the governorate's capital with WikiData Q7308711.
Results
Validation
Files Changed
contributions/cities/YE.json- Yemen cities cleaned and corrected (339 cities).github/fixes-docs/YEMEN_CITIES_CLEANUP.md- Comprehensive documentationReferences
Fixes #1155
Original prompt
Fixes #1155
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.