Conversation
dosubot
bot
added
size:M
dosubot
bot
added
size:S
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new city entry for Bwari in the Federal Capital Territory (FCT), Nigeria. The entry includes basic required fields and properly omits auto-managed fields.
Key changes:
- Adds Bwari city with correct state and country references (FCT, Nigeria)
- Includes timezone (Africa/Lagos) and WikiData ID (Q5003670)
- Missing critical translations field and recommended native field
| { | ||
| "name": "Bwari", | ||
| "state_id": 293, | ||
| "state_code": "FC", | ||
| "country_id": 161, | ||
| "country_code": "NG", | ||
| "latitude": "9.282563347732246", | ||
| "longitude": "7.379450945728134", | ||
| "timezone": "Africa/Lagos", | ||
| "wikiDataId": "Q5003670" | ||
| } |
There was a problem hiding this comment.
Missing recommended native field. While this field is optional, it's highly recommended for data completeness and is present in most other entries in this file.
For Bwari (a Nigerian city), the native name is likely "Bwari" itself, but this should be verified and explicitly set.
| "latitude": "9.282563347732246", | ||
| "longitude": "7.379450945728134", |
There was a problem hiding this comment.
[nitpick] Coordinate precision is inconsistent with existing entries. Most cities in this file use 8 decimal places (e.g., "5.10658000"), but this entry uses 15 decimal places ("9.282563347732246").
For consistency and practical purposes, coordinates should be formatted to 8 decimal places:
"latitude": "9.28256335""longitude": "7.37945095"
Note: 8 decimal places provides precision to ~1mm, which is more than sufficient for city-level location data.
| "latitude": "9.282563347732246", | |
| "longitude": "7.379450945728134", | |
| "latitude": "9.28256335", | |
| "longitude": "7.37945095", |
| { | ||
| "name": "Bwari", | ||
| "state_id": 293, | ||
| "state_code": "FC", | ||
| "country_id": 161, | ||
| "country_code": "NG", | ||
| "latitude": "9.282563347732246", | ||
| "longitude": "7.379450945728134", | ||
| "timezone": "Africa/Lagos", | ||
| "wikiDataId": "Q5003670" | ||
| } |
There was a problem hiding this comment.
Missing required translations field. According to the project guidelines, translations are MANDATORY for data quality.
Use the automatic enrichment tool to add translations:
python3 bin/scripts/validation/translation_enricher.py \
--file contributions/cities/NG.json \
--type city \
--entity "Bwari"This tool fetches authentic translations from Wikipedia in 18+ languages (ar, de, es, fr, hi, it, ja, ko, pt, ru, zh, etc.) for free.
|
Fixed in #1293 |
I added a data entry for missing city "Bwari" in FCT, Nigeria