Tobi bwari #1224
Added Bwari as city
- Loading branch information
commit 1524cf8c774534f5749ca530a2bbd89a63cf5dd8
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17188,5 +17188,16 @@ | |
| "longitude": "5.328547174323522", | ||
| "timezone": "Africa/Lagos", | ||
| "wikiDataId": "Q7116252" | ||
| }, | ||
| { | ||
| "name": "Bwari", | ||
| "state_id": 293, | ||
| "state_code": "FC", | ||
| "country_id": 161, | ||
| "country_code": "NG", | ||
| "latitude": "9.282563347732246", | ||
| "longitude": "7.379450945728134", | ||
| "timezone": "Africa/Lagos", | ||
| "wikiDataId": "Q5003670" | ||
| } | ||
|
Comment on lines
+17204
to
17214
There was a problem hiding this comment. Missing recommended For Bwari (a Nigerian city), the native name is likely "Bwari" itself, but this should be verified and explicitly set.
Comment on lines
+17204
to
17214
There was a problem hiding this comment. Missing required Use the automatic enrichment tool to add translations: python3 bin/scripts/validation/translation_enricher.py \
--file contributions/cities/NG.json \
--type city \
--entity "Bwari"This tool fetches authentic translations from Wikipedia in 18+ languages (ar, de, es, fr, hi, it, ja, ko, pt, ru, zh, etc.) for free. |
||
| ] | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Coordinate precision is inconsistent with existing entries. Most cities in this file use 8 decimal places (e.g., "5.10658000"), but this entry uses 15 decimal places ("9.282563347732246").
For consistency and practical purposes, coordinates should be formatted to 8 decimal places:
"latitude": "9.28256335""longitude": "7.37945095"Note: 8 decimal places provides precision to ~1mm, which is more than sufficient for city-level location data.