Skip to content

fix/top set crash#11

Merged
bishalfan merged 2 commits into
feature/android-pipfrom
fix/top-set-crash
Oct 13, 2021
Merged

fix/top set crash#11
bishalfan merged 2 commits into
feature/android-pipfrom
fix/top-set-crash

Conversation

@bishalfan

@bishalfan bishalfan commented Aug 7, 2021

Copy link
Copy Markdown

Crash

https://app.bugsnag.com/sporta-technologies-private-limited/fancode/errors/6083d0cd12ba7c0007f3334f?event_id=610d65d2007f877c8fca0000&i=sk&m=ef

  • feat(PIP-android): intial code added for PIP android
  • feat(floating): added pip floating layout
  • feat(customPIP): implemented customPIP for android
  • feat(native): native pip support added
  • feat(pip): custom pip implemnted for android
  • feat(touch): touch issue solved for samsung, and native pip code added to make animation smooth
  • feat(pip): use cases handled for multiactivty and bottom nav
  • fix(pip-ios): skipped event register for ios
  • fix(pip): added null checks and compatibility checks for controllers
  • refactor(backmerge): backmerge with master
  • feat(pip-home): pip implemented on home-screen button
  • chore(lint): runs lint fix
  • fix(ios): fixes build issues
  • fix(pip): fixes calling suspend fn errors
  • fix(switchtopip): fixes viewDidAppear not called
  • fix(backbutton): back button option logic changes
  • fix(transition): transition issues fixed for outside pip
  • feat(pip-back): pip implemented on back button
  • feat(pipbuttons): implemented pipbuttons
  • fix(status): pip getting hide behind status bar
  • fix(pip): pip back button issues fixed
  • fix(pip): pip button layout background changes
  • fix(pip): pip button layout changes
  • feat(pip): pip implemented on back and home button
  • fix(pip): pip squizing issue fixed
  • fix(appstate): refactor logic of app state background/foreground
  • fix(jsdevreloadhandler.java): try catch added for crashes on jsdev resume
  • fix(crash): crash fixes
  • fix(NavigationActivity.java): native backpress crash in PIP edge case catched
  • chore(package.json): verison udpate
  • feat(NavigationActivity): handle exit method added back (feat(NavigationActivity): handle exit method added back #7)
  • fix(NavigationActivity.java): unwanted check removed from onDestroy (fix(NavigationActivity.java): unwanted check removed from onDestroy #8)
  • fix(scoreupdate): fixed score update issue
  • fix(destoryed): added check for activity destroyed
  • fix(Bottomtabs.java): visibility changed for bottomnavs properly to make it hide (fix(Bottomtabs.java): visibility changed for bottomnavs properly to make it hide #10)
  • fix(NavigationActivity.java): solving issue of PIP disabled by user
  • fix(StackPresenter.java): added check for topbar null

@bishalfan bishalfan changed the base branch from master to feature/android-pip August 7, 2021 04:30
@bishalfan bishalfan requested a review from rahulfancode August 7, 2021 04:30
@rahulfancode rahulfancode changed the base branch from feature/android-pip to master September 23, 2021 11:05
@bishalfan bishalfan force-pushed the fix/top-set-crash branch 4 times, most recently from d8f6be3 to ab98273 Compare October 13, 2021 11:37
@bishalfan bishalfan changed the base branch from master to feature/android-pip October 13, 2021 11:44
@bishalfan bishalfan merged commit 118ec1e into feature/android-pip Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants