fix(NavigationActivity.java): unwanted check removed from onDestroy#8
Merged
Merged
Conversation
shwetsolanki
approved these changes
May 2, 2021
Merged
rahulfancode
added a commit
that referenced
this pull request
Sep 23, 2021
* feat(PIP-android): intial code added for PIP android * feat(floating): added pip floating layout * feat(customPIP): implemented customPIP for android * feat(native): native pip support added * feat(pip): custom pip implemnted for android * feat(touch): touch issue solved for samsung, and native pip code added to make animation smooth * feat(pip): use cases handled for multiactivty and bottom nav * fix(pip-ios): skipped event register for ios * fix(pip): added null checks and compatibility checks for controllers * refactor(backmerge): backmerge with master * feat(pip-home): pip implemented on home-screen button * chore(lint): runs lint fix * fix(ios): fixes build issues * fix(pip): fixes calling suspend fn errors * fix(switchtopip): fixes viewDidAppear not called * fix(backbutton): back button option logic changes * fix(transition): transition issues fixed for outside pip * feat(pip-back): pip implemented on back button * feat(pipbuttons): implemented pipbuttons * fix(status): pip getting hide behind status bar * fix(pip): pip back button issues fixed * fix(pip): pip button layout background changes * fix(pip): pip button layout changes * feat(pip): pip implemented on back and home button * fix(pip): pip squizing issue fixed * fix(appstate): refactor logic of app state background/foreground * fix(jsdevreloadhandler.java): try catch added for crashes on jsdev resume * fix(crash): crash fixes * fix(NavigationActivity.java): native backpress crash in PIP edge case catched * chore(package.json): verison udpate * feat(NavigationActivity): handle exit method added back (#7) * fix(NavigationActivity.java): unwanted check removed from onDestroy (#8) * fix(scoreupdate): fixed score update issue * fix(destoryed): added check for activity destroyed * fix(Bottomtabs.java): visibility changed for bottomnavs properly to make it hide (#10) Co-authored-by: Bishal Biswas <bishalbiswas@FC-BishalBiswasTemp.local> * fix(NavigationActivity.java): solving issue of PIP disabled by user * refactor(pip): refactored pip anaimation workingn * fix(options): fixed imports * fix(pip): removed element transation support forpip * fix(pip): removed element transation support forpip Co-authored-by: Shwet Solanki <shwet@dream11.com> Co-authored-by: Shwet Solanki <shwetsolanki@gmail.com> Co-authored-by: Bishal Biswas <bishalbiswas@FC-BishalBiswas.local> Co-authored-by: Bishal <bishal@fancode.com> Co-authored-by: bishalfan <60878859+bishalfan@users.noreply.github.com> Co-authored-by: Bishal Biswas <bishalbiswas@FC-BishalBiswasTemp.local>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue of app not opening after screen lock while PIP native mounted is solved
Screen_Recording_20210429-110543_FC-Prod.mp4