fix(tool-emulation): use gpt_native dialect for glm-5.2 - #204
Merged
Conversation
glm-5.2 ignores the glm47 XML tool-call markup and answers in prose. Switch it (and its variant SKU aliases) to the gpt_native function_call JSON dialect, which is emitted reliably and parsed correctly. Keep an env override (WINDSURFAPI_FORCE_TOOL_DIALECT) for tests.
dwgx
added a commit
that referenced
this pull request
Jun 28, 2026
Add regression coverage for the dialect routing merged in #204: glm-5.2 and glm-5-2-* variants resolve to gpt_native while older GLM SKUs stay on glm47, plus the WINDSURFAPI_FORCE_TOOL_DIALECT override (including that an unrecognized value falls through to normal routing).
dwgx
added a commit
that referenced
this pull request
Jun 29, 2026
Backfill contributors who were merged but never added to the thanks page, with weight tiers calibrated against existing entries: - #64 baily-zhang (S) — cascade transport canceled-session recovery - #163 you922 (A) — LS crash self-heal: exponential-backoff restart - #204 lovivi (B+) — glm-5.2 gpt_native tool dialect fix - #90 smeinecke (B+) — inline proxy on add-account form - #88 smeinecke (B+) — ALLOW_PRIVATE_PROXY_HOSTS opt-in for local proxy - #89 smeinecke (B) — login-flow i18n + error-code standardization Synced src -> docs via sync:contributors. Also gitignore .workflow-results/ (local audit artifacts, not source). dashboard tests 17/17.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
glm-5.2 ignores the glm47 XML tool-call markup and answers in prose. Switch it and its variant SKU aliases to the gpt_native function_call JSON dialect, which is emitted reliably and parsed correctly.