Fix missing/broken i18n - #89

Merged

dwgx merged 4 commits into

dwgx:masterfrom

smeinecke:fix/missing-i18n

Apr 29, 2026

smeinecke commented Apr 28, 2026

Contributor

改了什么 / What changed

Fixed i18n translation for all error codes in dashboard login flows (toasts, result displays, and login history)
Standardized error code naming: ERR_PRIVATE_IP → ERR_PROXY_PRIVATE_IP, ERR_PRIVATE_HOST → ERR_PROXY_PRIVATE_HOST
Added missing ERR_PROXY_PRIVATE_HOST translation key to both en.json and zh-CN.json
Improved language toggle UI with dynamic tooltip showing target language

为什么 / Why

Fixes the issue where error codes like ERR_NO_PASSWORD_SET were displayed raw in toasts and login history instead of human-readable translations. Also aligns error code naming with existing ERR_PROXY_PRIVATE_IP for consistency.

测试 / Testing

Dashboard login with OAuth/password errors now shows translated messages in toasts
Login History table displays translated error messages with original code in tooltip
Language switcher tooltip correctly shows "Switch to English" / "切换到中文" based on current locale
No new npm dependencies (zero-dep project)

Checklist

代码风格和现有文件一致 / Code style matches existing files
没有引入 npm 依赖 / No new npm dependencies (project is zero-dep)
涉及 LS binary 协议改动时在 PR 描述里注明字段号来源 / If touching LS protocol, document field-number source in the PR description
涉及 dashboard UI 用 App.confirm / App.prompt 不用浏览器原生 alert/confirm / Uses App.confirm / App.prompt, not native dialogs (if dashboard)

smeinecke added 4 commits

April 28, 2026 20:42


          fix(dashboard): translate error messages in Windsurf login flows when…

aed4351

… i18n keys exist

All Windsurf login error display paths (single/batch/import) now attempt I18n.t() on error strings before rendering. If the error message is a known i18n key (I18n.t(err) !== err), use the translated version; otherwise fall back to the raw error string. Covers toast notifications, status text, result cards, and batch table cells.


          fix(dashboard): improve i18n UX — full-word lang toggle + auto-refres…

4dd7b9e

…h panels + error.* namespace

Language toggle button now shows "中文"/"English" full words instead of "中"/"EN" abbreviations, with dynamic title tooltip ("Switch to English" / "切换到中文"). toggleLang() made async and triggers refreshActivePanelI18n() to reload the active panel's content after locale switch, so users see translated UI immediately without manual navigation.


          fix(i18n): add ERR_PROXY_PRIVATE_HOST translation + rename net-safety…

94509b9

… error codes

Dashboard i18n now includes ERR_PROXY_PRIVATE_HOST ("Private/local host is not allowed" / "内网/本地主机不允许"). net-safety.js error codes renamed from ERR_PRIVATE_HOST/ERR_PRIVATE_IP to ERR_PROXY_PRIVATE_HOST/ERR_PROXY_PRIVATE_IP for consistency with error.* namespace convention.


          test(ssrf): update error code assertion to match ERR_PROXY_PRIVATE_IP…

112e3da

… rename

Follows the error code rename from ERR_PRIVATE_IP to ERR_PROXY_PRIVATE_IP introduced in 94509b9 (net-safety.js error codes standardized to error.* namespace convention). Also removes trailing blank lines.

dwgx merged commit 2cded99 into dwgx:master

2 checks passed

dwgx mentioned this pull request

Add proxy support for add account by token #90

Merged

4 tasks

dwgx added a commit that referenced this pull request


          chore: 2.0.27 — i18n guard 收尾 + PR #88 #89 合并后

1526b40

- check-i18n.js: bare identifier 不再误报缺失 key (errKey/errCode/etc)
- 补 action.revealKey 翻译（v2.0.26 之前就缺，hardcoded fallback 已去）
- 新增 footer.langToggleTo{En,Zh} 给 PR #89 引入的 toggleBtn.title 用，去掉硬编码 '切换到中文'
- 全部 i18n 检查 + 311/311 tests pass

smeinecke deleted the fix/missing-i18n branch

April 29, 2026 09:11

huanchen pushed a commit to huanchen/WindsurfAPI that referenced this pull request


          Merge pull request dwgx#89 from smeinecke/fix/missing-i18n

2e52ef6

Merging i18n fixes from @smeinecke. Thanks!

Notes for follow-up (will fix in v2.0.27):
- `toggleBtn.title = zhMode ? 'Switch to English' : '切换到中文'` introduces a hardcoded Chinese string that fails `node src/dashboard/check-i18n.js`. Will replace with `data-i18n-title` attribute pattern.
- The `error.${err.message}` lookup pattern is duplicated across 6 sites — will centralize into an `App.translateError(code, fallback)` helper next pass.
- Will also clean up the `action.revealKey` pre-existing miss while there.

huanchen pushed a commit to huanchen/WindsurfAPI that referenced this pull request


          chore: 2.0.27 — i18n guard 收尾 + PR dwgx#88 dwgx#89 合并后

458f22f

- check-i18n.js: bare identifier 不再误报缺失 key (errKey/errCode/etc)
- 补 action.revealKey 翻译（v2.0.26 之前就缺，hardcoded fallback 已去）
- 新增 footer.langToggleTo{En,Zh} 给 PR dwgx#89 引入的 toggleBtn.title 用，去掉硬编码 '切换到中文'
- 全部 i18n 检查 + 311/311 tests pass

dwgx added a commit that referenced this pull request


          Merge pull request #89 from smeinecke/fix/missing-i18n

34da171

Merging i18n fixes from @smeinecke. Thanks!

Notes for follow-up (will fix in v2.0.27):
- `toggleBtn.title = zhMode ? 'Switch to English' : '切换到中文'` introduces a hardcoded Chinese string that fails `node src/dashboard/check-i18n.js`. Will replace with `data-i18n-title` attribute pattern.
- The `error.${err.message}` lookup pattern is duplicated across 6 sites — will centralize into an `App.translateError(code, fallback)` helper next pass.
- Will also clean up the `action.revealKey` pre-existing miss while there.

dwgx added a commit that referenced this pull request


          chore: 2.0.27 — i18n guard 收尾 + PR #88 #89 合并后

d933a7b

- check-i18n.js: bare identifier 不再误报缺失 key (errKey/errCode/etc)
- 补 action.revealKey 翻译（v2.0.26 之前就缺，hardcoded fallback 已去）
- 新增 footer.langToggleTo{En,Zh} 给 PR #89 引入的 toggleBtn.title 用，去掉硬编码 '切换到中文'
- 全部 i18n 检查 + 311/311 tests pass

dwgx added a commit that referenced this pull request


          Merge pull request #89 from smeinecke/fix/missing-i18n

971cc56

Merging i18n fixes from @smeinecke. Thanks!

Notes for follow-up (will fix in v2.0.27):
- `toggleBtn.title = zhMode ? 'Switch to English' : '切换到中文'` introduces a hardcoded Chinese string that fails `node src/dashboard/check-i18n.js`. Will replace with `data-i18n-title` attribute pattern.
- The `error.${err.message}` lookup pattern is duplicated across 6 sites — will centralize into an `App.translateError(code, fallback)` helper next pass.
- Will also clean up the `action.revealKey` pre-existing miss while there.

dwgx added a commit that referenced this pull request


          chore: 2.0.27 — i18n guard 收尾 + PR #88 #89 合并后

d7e0fe5

- check-i18n.js: bare identifier 不再误报缺失 key (errKey/errCode/etc)
- 补 action.revealKey 翻译（v2.0.26 之前就缺，hardcoded fallback 已去）
- 新增 footer.langToggleTo{En,Zh} 给 PR #89 引入的 toggleBtn.title 用，去掉硬编码 '切换到中文'
- 全部 i18n 检查 + 311/311 tests pass

dwgx added a commit that referenced this pull request


          Merge pull request #89 from smeinecke/fix/missing-i18n

81606ae

Merging i18n fixes from @smeinecke. Thanks!

Notes for follow-up (will fix in v2.0.27):
- `toggleBtn.title = zhMode ? 'Switch to English' : '切换到中文'` introduces a hardcoded Chinese string that fails `node src/dashboard/check-i18n.js`. Will replace with `data-i18n-title` attribute pattern.
- The `error.${err.message}` lookup pattern is duplicated across 6 sites — will centralize into an `App.translateError(code, fallback)` helper next pass.
- Will also clean up the `action.revealKey` pre-existing miss while there.

dwgx added a commit that referenced this pull request


          chore: 2.0.27 — i18n guard 收尾 + PR #88 #89 合并后

77738c5

- check-i18n.js: bare identifier 不再误报缺失 key (errKey/errCode/etc)
- 补 action.revealKey 翻译（v2.0.26 之前就缺，hardcoded fallback 已去）
- 新增 footer.langToggleTo{En,Zh} 给 PR #89 引入的 toggleBtn.title 用，去掉硬编码 '切换到中文'
- 全部 i18n 检查 + 311/311 tests pass

dwgx added a commit that referenced this pull request


          Merge pull request #89 from smeinecke/fix/missing-i18n

e2c951b

Merging i18n fixes from @smeinecke. Thanks!

Notes for follow-up (will fix in v2.0.27):
- `toggleBtn.title = zhMode ? 'Switch to English' : '切换到中文'` introduces a hardcoded Chinese string that fails `node src/dashboard/check-i18n.js`. Will replace with `data-i18n-title` attribute pattern.
- The `error.${err.message}` lookup pattern is duplicated across 6 sites — will centralize into an `App.translateError(code, fallback)` helper next pass.
- Will also clean up the `action.revealKey` pre-existing miss while there.

dwgx added a commit that referenced this pull request


          chore: 2.0.27 — i18n guard 收尾 + PR #88 #89 合并后

b933fb8

- check-i18n.js: bare identifier 不再误报缺失 key (errKey/errCode/etc)
- 补 action.revealKey 翻译（v2.0.26 之前就缺，hardcoded fallback 已去）
- 新增 footer.langToggleTo{En,Zh} 给 PR #89 引入的 toggleBtn.title 用，去掉硬编码 '切换到中文'
- 全部 i18n 检查 + 311/311 tests pass

dwgx added a commit that referenced this pull request


          docs(thanks): add 6 missing merged-PR contributors

5dace50

Backfill contributors who were merged but never added to the thanks
page, with weight tiers calibrated against existing entries:

- #64  baily-zhang (S)  — cascade transport canceled-session recovery
- #163 you922 (A)       — LS crash self-heal: exponential-backoff restart
- #204 lovivi (B+)      — glm-5.2 gpt_native tool dialect fix
- #90  smeinecke (B+)   — inline proxy on add-account form
- #88  smeinecke (B+)   — ALLOW_PRIVATE_PROXY_HOSTS opt-in for local proxy
- #89  smeinecke (B)    — login-flow i18n + error-code standardization

Synced src -> docs via sync:contributors. Also gitignore .workflow-results/
(local audit artifacts, not source). dashboard tests 17/17.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet