16502 refactor rpcprotocol by tsmaeder · Pull Request #971 · eclipse-che/che-theia

tsmaeder · 2021-01-26T09:17:55Z

What does this PR do?

This PR adapts che-theia to the upstream PR eclipse-theia/theia#8972. As such, I'll leave it in draft PR staus until upstream is merged. It is still open for review.

What issues does this PR fix or reference?

This is a refactoring and as such not related to a PR. See upstream PR for justification.

How to test this PR?

Use local and remote plugins in a workspace based on the results of this PR build. (self-hosting or via the image built for the happy-path tests.

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Happy Path Channel

HAPPY_PATH_CHANNEL=next

che-bot · 2021-01-26T09:30:11Z

❌ E2E Happy path tests failed ❗

See Details

name	link
che-theia	docker.io/maxura/che-theia:971
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:971

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

che-bot · 2021-02-04T14:33:56Z

❌ E2E Happy path tests failed ❗

See Details

name	link
che-theia	docker.io/maxura/che-theia:971
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:971

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

tsmaeder · 2021-02-08T08:55:31Z

Since I have two thumbs up on the upstream PR, I'm removing the "draft" status, Reviewers, please review!

azatsarynnyy

The code looks good to me, as it's just an adaptation to the upstream refactoring.
Let us know once a Che-Theia image is ready for testing the PR.

azatsarynnyy · 2021-02-08T18:42:32Z

extensions/eclipse-che-theia-plugin-remote/src/node/hosted-plugin-remote.ts


  @postConstruct()
  protected postConstruct(): void {
+    console.log('hosted plugin remote postconstruct');


Do we need to keep this log or it's just a leftover?

tsmaeder · 2021-02-09T08:55:29Z

Let us know once a Che-Theia image is ready for testing the PR.

I honestly don't know how to create one: the Github action PR checks don't publish images and the "happy path" CI job doesn't have the ability to work with Theia branches. 🤷 I guess self-hosting is the process to test in this case.

benoitf · 2021-02-09T08:57:25Z

@tsmaeder you could change in build.include file the branch used

tsmaeder · 2021-02-09T09:36:14Z

Hmh...does the plugin-host executable get rebuilt when we rebuild the che-theia image? Not sure anymore. Because the protocol between back-end and plugin host changed. @benoitf what would be the right way to test that?

benoitf · 2021-02-09T09:42:14Z

@tsmaeder yes it builds the endpoint image as well

Right way: tune build.include to include remote upstream theia branch/fork instead of eclipse-theia/theia + master so Happy path will deploy both custom theia and custom theia endpoint (so it will validate if communication across containers/VS Code extensions works fine)

che-bot · 2021-03-10T14:41:40Z

❌ E2E Happy path tests failed ❗

See Details

name	link
che-theia	quay.io/crw_pr/che-theia:971
che-theia-endpoint-runtime-binary	quay.io/crw_pr/che-theia-endpoint-runtime-binary:971

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

tsmaeder · 2021-03-10T20:41:35Z

[crw-ci-test]

che-bot · 2021-03-10T20:46:26Z

❌ E2E Happy path tests failed ❗

See Details

name	link
che-theia	quay.io/crw_pr/che-theia:971
che-theia-endpoint-runtime-binary	quay.io/crw_pr/che-theia-endpoint-runtime-binary:971

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

tsmaeder · 2021-03-10T21:13:14Z

[crw-ci-test --rebuild]

che-bot · 2021-03-10T22:07:26Z

✅ E2E Happy path tests succeed 🎉

See Details

name	link
che-theia	quay.io/crw_pr/che-theia:971
che-theia-endpoint-runtime-binary	quay.io/crw_pr/che-theia-endpoint-runtime-binary:971

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

tsmaeder · 2021-03-12T09:25:28Z

@benoitf @azatsarynnyy we have an image being built now. Could you test, please?

benoitf · 2021-03-15T08:00:53Z

let's merge it after 7.28.0 is tagged (ie: for 7.29.0 so it'll be a new CRW/Che lifecycle)

che-bot · 2021-03-19T16:19:19Z

✅ E2E Happy path tests succeed 🎉

See Details

name	link
che-theia	quay.io/crw_pr/che-theia:971
che-theia-endpoint-runtime-binary	quay.io/crw_pr/che-theia-endpoint-runtime-binary:971

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

ericwill · 2021-04-06T13:30:52Z

@tsmaeder what's the status of this PR?

tsmaeder · 2021-04-06T14:03:35Z

When I get a moment, I need to rebase the upstream PR before I can merge both.

benoitf · 2021-04-06T14:08:41Z

now, we're at 2/3 of the sprint (my previous comment was 3 weeks ago) so it's not becoming a good time to merge refactoring upstream/downstream stuff

che-bot · 2021-04-08T13:37:00Z

❌ E2E Happy path tests failed ❗

See Details

name	link
che-theia	quay.io/crw_pr/che-theia:971
che-theia-endpoint-runtime-binary	quay.io/crw_pr/che-theia-endpoint-runtime-binary:971

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

build.include

che-bot · 2021-04-08T20:30:52Z

❌ E2E Happy path tests failed ❗

See Details

name	link
che-theia	quay.io/crw_pr/che-theia:971
che-theia-endpoint-runtime-binary	quay.io/crw_pr/che-theia-endpoint-runtime-binary:971

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Signed-off-by: Thomas Mäder <tmader@redhat.com>

che-bot · 2021-04-23T10:25:25Z

✅ E2E Happy path tests succeed 🎉

See Details

name	link
che-theia	quay.io/crw_pr/che-theia:971
che-theia-endpoint-runtime-binary	quay.io/crw_pr/che-theia-endpoint-runtime-binary:971

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Signed-off-by: tsmaeder <tmader@redhat.com>

tsmaeder · 2021-04-23T12:27:16Z

[crw-ci-test --rebuild]

che-bot · 2021-04-23T13:06:11Z

✅ E2E Happy path tests succeed 🎉

See Details

name	link
che-theia	quay.io/crw_pr/che-theia:971
che-theia-endpoint-runtime-binary	quay.io/crw_pr/che-theia-endpoint-runtime-binary:971

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Signed-off-by: tsmaeder <tmader@redhat.com>

che-bot · 2021-04-23T15:04:39Z

✅ E2E Happy path tests succeed 🎉

See Details

name	link
che-theia	quay.io/crw_pr/che-theia:971
che-theia-endpoint-runtime-binary	quay.io/crw_pr/che-theia-endpoint-runtime-binary:971

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Signed-off-by: tsmaeder <tmader@redhat.com>

codecov · 2021-04-23T15:27:49Z

Codecov Report

Merging #971 (2c0c94c) into master (eeb4526) will increase coverage by 2.04%.
The diff coverage is 42.40%.

@@            Coverage Diff             @@
##           master     #971      +/-   ##
==========================================
+ Coverage   29.45%   31.50%   +2.04%     
==========================================
  Files         277      278       +1     
  Lines        9336     9469     +133     
  Branches     1380     1419      +39     
==========================================
+ Hits         2750     2983     +233     
+ Misses       6487     6484       -3     
+ Partials       99        2      -97

Impacted Files	Coverage Δ
...theia-about/src/browser/about-che-theia-dialog.tsx	`0.00% <ø> (ø)`
...ovisioner/src/node/git-configuration-controller.ts	`0.00% <0.00%> (ø)`
...eia-plugin-remote/src/node/hosted-plugin-remote.ts	`0.00% <0.00%> (ø)`
...theia-plugin-remote/src/node/plugin-host-custom.ts	`0.00% <0.00%> (ø)`
...in-remote/src/node/plugin-remote-backend-module.ts	`0.00% <0.00%> (ø)`
...theia-plugin-remote/src/node/plugin-remote-init.ts	`0.00% <0.00%> (ø)`
...-che-theia-plugin-remote/src/node/plugin-remote.ts	`0.00% <0.00%> (ø)`
...ugin-remote/src/node/server-plugin-proxy-runner.ts	`0.00% <0.00%> (ø)`
...plugin-remote/src/node/terminal-container-aware.ts	`0.00% <0.00%> (ø)`
...a-plugin-remote/src/node/webviews-content-aware.ts	`0.00% <0.00%> (ø)`
... and 90 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e38b437...2c0c94c. Read the comment docs.

che-bot · 2021-04-23T15:51:26Z

✅ E2E Happy path tests succeed 🎉

See Details

name	link
che-theia	quay.io/crw_pr/che-theia:971
che-theia-endpoint-runtime-binary	quay.io/crw_pr/che-theia-endpoint-runtime-binary:971

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

tsmaeder requested review from RomanNikitenko, azatsarynnyy, benoitf and vzhukovs as code owners January 26, 2021 09:17

tsmaeder marked this pull request as draft January 26, 2021 09:26

tsmaeder force-pushed the 16502_refactor_rpcprotocol branch from 6f79c05 to e6d147d Compare February 4, 2021 14:19

tsmaeder marked this pull request as ready for review February 8, 2021 08:54

azatsarynnyy reviewed Feb 8, 2021

View reviewed changes

tsmaeder force-pushed the 16502_refactor_rpcprotocol branch from e6d147d to 20976ee Compare March 10, 2021 14:28

azatsarynnyy approved these changes Mar 18, 2021

View reviewed changes

tsmaeder force-pushed the 16502_refactor_rpcprotocol branch from 20976ee to 939dce4 Compare March 19, 2021 15:41

tsmaeder force-pushed the 16502_refactor_rpcprotocol branch from 939dce4 to 0fc4429 Compare April 8, 2021 13:05

vitaliy-guliy reviewed Apr 8, 2021

View reviewed changes

build.include Outdated Show resolved Hide resolved

tsmaeder force-pushed the 16502_refactor_rpcprotocol branch from 250ef27 to 52d25d9 Compare April 8, 2021 14:48

tsmaeder added 2 commits April 23, 2021 08:55

Initial fixes

537eda7

Signed-off-by: Thomas Mäder <tmader@redhat.com>

Fix formatting

467ae97

Signed-off-by: Thomas Mäder <tmader@redhat.com>

tsmaeder force-pushed the 16502_refactor_rpcprotocol branch from 52d25d9 to 467ae97 Compare April 23, 2021 09:50

Cleanup

ba14e58

Signed-off-by: tsmaeder <tmader@redhat.com>

update yarn.lock

7840795

Signed-off-by: tsmaeder <tmader@redhat.com>

Update yarn.lock

2c0c94c

Signed-off-by: tsmaeder <tmader@redhat.com>

tsmaeder merged commit 534cfad into eclipse-che:master Apr 23, 2021

che-bot added this to the 7.30 milestone Apr 23, 2021

Conversation

tsmaeder commented Jan 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

What issues does this PR fix or reference?

How to test this PR?

PR Checklist

Reviewers

Happy Path Channel

Uh oh!

che-bot commented Jan 26, 2021

Uh oh!

che-bot commented Feb 4, 2021

Uh oh!

tsmaeder commented Feb 8, 2021

Uh oh!

azatsarynnyy left a comment

Choose a reason for hiding this comment

Uh oh!

azatsarynnyy Feb 8, 2021

Choose a reason for hiding this comment

Uh oh!

tsmaeder commented Feb 9, 2021

Uh oh!

benoitf commented Feb 9, 2021

Uh oh!

tsmaeder commented Feb 9, 2021

Uh oh!

benoitf commented Feb 9, 2021

Uh oh!

che-bot commented Mar 10, 2021

Uh oh!

tsmaeder commented Mar 10, 2021

Uh oh!

che-bot commented Mar 10, 2021

Uh oh!

tsmaeder commented Mar 10, 2021

Uh oh!

che-bot commented Mar 10, 2021

Uh oh!

tsmaeder commented Mar 12, 2021

Uh oh!

benoitf commented Mar 15, 2021

Uh oh!

che-bot commented Mar 19, 2021

Uh oh!

ericwill commented Apr 6, 2021

Uh oh!

tsmaeder commented Apr 6, 2021

Uh oh!

benoitf commented Apr 6, 2021

Uh oh!

che-bot commented Apr 8, 2021

Uh oh!

Uh oh!

che-bot commented Apr 8, 2021

Uh oh!

che-bot commented Apr 23, 2021

Uh oh!

tsmaeder commented Apr 23, 2021

Uh oh!

che-bot commented Apr 23, 2021

Uh oh!

che-bot commented Apr 23, 2021

Uh oh!

codecov bot commented Apr 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

che-bot commented Apr 23, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

tsmaeder commented Jan 26, 2021 •

edited

Loading

codecov bot commented Apr 23, 2021 •

edited

Loading