Merged
Conversation
33 tasks
9 tasks
Member
paul-marechal
left a comment
There was a problem hiding this comment.
I don't fully understand the system, but so far those changes are looking good to me.
Member
Author
|
@marechal-p thx for the review. |
Contributor
|
Hello, I still don't get the real benefits, ( |
benoitf
approved these changes
Jan 27, 2021
Contributor
benoitf
left a comment
There was a problem hiding this comment.
I don't see regression using Theia
paul-marechal
approved these changes
Feb 4, 2021
Member
|
@tsmaeder merge at will. |
Member
Author
|
@marechal-p Not merging because of downstream reasons 🤷 . |
72dd264 to
1025a94
Compare
1025a94 to
5128136
Compare
5128136 to
8b93e69
Compare
8b93e69 to
d44b0a4
Compare
Signed-off-by: Thomas Mäder <tmader@redhat.com>
d44b0a4 to
dbf86d2
Compare
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
This refactoring clarifies an decouples a bunch of things. This is a pure refactoring which should not change behaviour.
How to test
Run Theia with with at least a back-end and one front-end plugin. No exceptions related to rpc processing should appear in neither the back-end nor front-end logs.
Note: front-end plugins still don't work with electron.
Review checklist
Reminder for reviewers