-
Notifications
You must be signed in to change notification settings - Fork 32
Closed
Labels
Description
The BaseGLSPClient should handle error on the connection better by trying a reconnect similar to how the BaseLSPClient is doing it.
Edit 2023-07-24:
We investigated WebSocket interrupts with the different example integrations.
The websocket server implementations will now handle a reconnect gracefully and respond to a RequestModelAction with the latest modelState (see eclipse-glsp/glsp-server-node#54 and eclipse-glsp/glsp-server#208).
Here is an overview of the examples that can already handle websocket connection interrupts:
- GLSP standalone example (GLSP-77: Allow WebSocket connections to reconnect after interrupt glsp-client#269)
- GLSP Eclipse integration example (GLSP-77: Allow WebSocket connections to reconnect after interrupt glsp-eclipse-integration#84)
- GLSP Theia integration example (Connect to a Websocket GLSP Server) (77: BaseGLSPClient should handle reconnect glsp-theia-integration#197)
- Main feature was implemented and merged, follow-up issues need to be fixed (listed here: 77: BaseGLSPClient should handle reconnect glsp-theia-integration#197 (review))
- Handle reconnect for direct WebSocket connection from Theia frontend #1275
- Handle reconnect for GLSP VS Code integration #1276
What is left to do:
Reactions are currently unavailable