Skip to content

Rename @Draft to @ProtocolDraft #928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pisv merged 1 commit into from
Nov 22, 2025
Merged

Rename @Draft to @ProtocolDraft #928

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions ...java/org/eclipse/lsp4j/jsonrpc/Draft.java → .../eclipse/lsp4j/jsonrpc/ProtocolDraft.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,8 @@
import java.lang.annotation.Target;

/**
* An API using this annotation is part of an upcomming Language Server Protocol Specification and
* in a draft state. Therefore it is subject to incompatible changes (including even removal)
* in a future release.
*
* An API using this annotation is part of an upcoming Protocol Specification and in a draft state.
Copy link
Contributor

@jonahgraham jonahgraham Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for generalizing the language here.

* Therefore it is subject to incompatible changes (including even removal) in a future release.
*/
@Retention(RetentionPolicy.CLASS)
@Target({
Expand All @@ -31,4 +29,4 @@
ElementType.TYPE
})
@Documented
public @interface Draft {}
public @interface ProtocolDraft {}
4 changes: 2 additions & 2 deletions org.eclipse.lsp4j/src/main/java/org/eclipse/lsp4j/ApplyKind.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,14 @@
******************************************************************************/
package org.eclipse.lsp4j;

import org.eclipse.lsp4j.jsonrpc.Draft;
import org.eclipse.lsp4j.jsonrpc.ProtocolDraft;

/**
* Defines how values from a set of defaults and an individual item will be merged.
* <p>
* Since 3.18.0
*/
@Draft
@ProtocolDraft
public enum ApplyKind {
/**
* The value from the individual item (if provided and not {@code null}) will be
Expand Down
4 changes: 2 additions & 2 deletions org.eclipse.lsp4j/src/main/java/org/eclipse/lsp4j/CodeActionTag.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,14 @@
******************************************************************************/
package org.eclipse.lsp4j;

import org.eclipse.lsp4j.jsonrpc.Draft;
import org.eclipse.lsp4j.jsonrpc.ProtocolDraft;

/**
* Code action tags are extra annotations that tweak the behavior of a code action.
* <p>
* Since 3.18.0
*/
@Draft
@ProtocolDraft
public enum CodeActionTag {
/**
* Marks the code action as LLM-generated.
Expand Down
4 changes: 2 additions & 2 deletions org.eclipse.lsp4j/src/main/java/org/eclipse/lsp4j/InlineCompletionTriggerKind.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,14 @@
******************************************************************************/
package org.eclipse.lsp4j;

import org.eclipse.lsp4j.jsonrpc.Draft;
import org.eclipse.lsp4j.jsonrpc.ProtocolDraft;

/**
* Describes how an inline completion request was triggered.
* <p>
* Since 3.18.0
*/
@Draft
@ProtocolDraft
public enum InlineCompletionTriggerKind {
/**
* Completion was triggered explicitly by a user gesture. Return multiple
Expand Down
4 changes: 2 additions & 2 deletions org.eclipse.lsp4j/src/main/java/org/eclipse/lsp4j/MessageType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
******************************************************************************/
package org.eclipse.lsp4j;

import org.eclipse.lsp4j.jsonrpc.Draft;
import org.eclipse.lsp4j.jsonrpc.ProtocolDraft;

public enum MessageType {

Expand Down Expand Up @@ -40,7 +40,7 @@ public enum MessageType {
* <p>
* Since 3.18.0
*/
@Draft
@ProtocolDraft
Debug(5);

private final int value;
Expand Down
Loading