Rename @Draft to @ProtocolDraft#928
Merged
pisv merged 1 commit intoeclipse-lsp4j:mainfrom Nov 22, 2025
Merged
Conversation
Renames the `@Draft` annotation to `@ProtocolDraft` for the sake of consistency with `@ProtocolDeprecated` and to reserve the `@Draft` annotation for LSP4J's own API.
jonahgraham
approved these changes
Nov 21, 2025
Contributor
jonahgraham
left a comment
jonahgraham
left a comment
There was a problem hiding this comment.
I do like the symmetry with @ProtocolDeprecated - if someone wants to do @ProtocolSince one day I would be in favour, although I doubt it is worth the effort. The documentation we provided in LSP4J for DAP/LSP is more of a courtesy to Java developers using the library and not a substitute for the official specs.
| * in a draft state. Therefore it is subject to incompatible changes (including even removal) | ||
| * in a future release. | ||
| * | ||
| * An API using this annotation is part of an upcoming Protocol Specification and in a draft state. |
Contributor
There was a problem hiding this comment.
Thanks for generalizing the language here.
Contributor
Author
|
@jonahgraham Thank you for your review! I also thought about introducing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames the
@Draftannotation to@ProtocolDraftfor the sake of consistency with@ProtocolDeprecatedand to reserve the@Draftannotation for LSP4J's own API.