Introduce the @ProtocolSince annotation#939
Merged
pisv merged 2 commits intoeclipse-lsp4j:mainfrom Dec 9, 2025
Merged
Conversation
Introduces the `@ProtocolSince` annotation to make it easier for API consumers to identify the version of a Protocol Specification in which the annotated element was first introduced. This complements the `@ProtocolDeprecated` and `@ProtocolDraft` annotations added earlier.
pisv
changed the title
@ProtocolSince annotation@ProtocolSince annotation
jonahgraham
reviewed
Dec 9, 2025
Contributor
jonahgraham
left a comment
jonahgraham
left a comment
There was a problem hiding this comment.
LGTM - apart from comment. I think it is great to fix the annotations so all the @Protocol... ones are done
This leaves an annoying corner case of fields that have new value types, such as
I am fine with how you have dealt with it, as I think anything else probably gets too complicated.
...eclipse.lsp4j.generator/src/main/java/org/eclipse/lsp4j/generator/JsonRpcDataProcessor.xtend
Show resolved
Hide resolved
Contributor
Author
Yes, |
Adds special support for `@ProtocolDeprecated`, `@ProtocolDraft`, and `@ProtocolSince` annotations when generating getters and setters for `@JsonRpcData`-annotated classes in `JsonRpcDataProcessor`.
jonahgraham
approved these changes
Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #928 (review):
Introduces the
@ProtocolSinceannotation to make it easier for API consumers to identify the version of a Protocol Specification in which the annotated element was first introduced. This complements the@ProtocolDeprecatedand@ProtocolDraftannotations added earlier.Adds special support for
@ProtocolDeprecated,@ProtocolDraft, and@ProtocolSinceannotations when generating getters and setters for@JsonRpcData-annotated classes inJsonRpcDataProcessor.