Skip to content

Fix state restoration in OutputWidget#16851

Merged
colin-grant-work merged 2 commits intomasterfrom
bugfix/output-only-on-change
Jan 23, 2026
Merged

Fix state restoration in OutputWidget#16851
colin-grant-work merged 2 commits intomasterfrom
bugfix/output-only-on-change

Conversation

@colin-grant-work
Copy link
Contributor

What it does

Fixes #11923

How to test

  1. Open the output widget and select a certain output channel.
  2. Reload the application
  3. That channel should be selected if available, and its content should be shown, if there is any.
  4. If it is not available (because of conditional extension activation, e.g.: try opening a TypeScript file, selecting the TS extension channel, then closing the file)...
    1. If you select another channel before the restored channel becomes available, that channel should be retained.
    2. If you do not explicitly select another channel before the restored channel becomes available, that channel should be selected when available.
  5. Close the output widget and reopen it in the same session.
  6. The same channel should be selected.

Follow-ups

Breaking changes

  • This PR introduces breaking changes and requires careful review. If yes, the breaking changes section in the changelog has been updated.

Attribution

Review checklist

Reminder for reviewers

@github-project-automation github-project-automation bot moved this to Waiting on reviewers in PR Backlog Jan 20, 2026
@ndoschek ndoschek self-requested a review January 23, 2026 11:50
Copy link
Member

@ndoschek ndoschek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Colin, changes LGTM and the state restoration works great for me!

@github-project-automation github-project-automation bot moved this from Waiting on reviewers to Needs merge in PR Backlog Jan 23, 2026
@colin-grant-work colin-grant-work merged commit c13611b into master Jan 23, 2026
10 checks passed
@colin-grant-work colin-grant-work deleted the bugfix/output-only-on-change branch January 23, 2026 15:33
@github-project-automation github-project-automation bot moved this from Needs merge to Done in PR Backlog Jan 23, 2026
@github-actions github-actions bot added this to the 1.68.0 milestone Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

output: selected channel is not properly restored on reload

2 participants