feat(vscode): add support for "workbench.extensions.installExtension" by fgreinacher · Pull Request #8745 · eclipse-theia/theia

fgreinacher · 2020-11-12T13:57:12Z

What it does

Adds support for the workbench.extensions.installExtension command (part of #8387).

We want this because we're considering to use https://github.com/joelspadin-garmin/vscode-private-extension-manager which depends on this API to install extensions.

🛠️ with ❤️ by @siemens

How to test

Build the Example app
Put the test extension in the plugins directory
Execute the command "Install extension via ID and VS Code API" with a valid an extension ID (e.g. redhat.java).
Execute the command "Install extension via VSIX and VS Code API" with the URI to a locally available VSIX file (something like file:///home/gitpod/temp/some-other.vsix)
Ensure that both extensions have been installed via the extension manager.

Review checklist

as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

as a reviewer, I agree to behave in accordance with the review guidelines

packages/plugin-ext-vscode/src/browser/plugin-vscode-commands-contribution.ts

fgreinacher · 2020-11-12T14:04:23Z

Am I missing anything important or is it really that simple? I could not find any existing tests for this layer, could you guide me a bit here?

vince-fugnitto

@fgreinacher can you update the 'how to test' section of the pull-request so reviewers can easily review and test the functionality? Generally, in order to review changes to the plugin API, a corresponding plugin is provided or implemented to validate the feature.

DucNgn · 2020-11-13T15:14:41Z

I created a quick test plugin to verify this PR. But the changes are not working on my side atm.

Steps

Download test plugin (source code) and place in plugins folder in theia.
Restart the example application.
Call Install Material Theme Icons (test installing extension by id) from the command palette.
Material Theme Icons should be installed (it is not currently).

fgreinacher · 2020-11-13T22:05:56Z

Thanks a ton @dukengn!

I played around a bit. The problem is that the plugin server currently cannot deploy .vsix files. Deploying extensions by ID works when adding the vscode:extension/ prefix, e.g. `vscode:extension/pkief.material-icon-theme".

packages/plugin-ext-vscode/src/browser/plugin-vscode-commands-contribution.ts

packages/plugin-ext/src/main/node/resolvers/plugin-local-file-resolver.ts

fgreinacher · 2020-11-14T01:31:48Z

@fgreinacher can you update the 'how to test' section of the pull-request so reviewers can easily review and test the functionality? Generally, in order to review changes to the plugin API, a corresponding plugin is provided or implemented to validate the feature.

@vince-fugnitto I added some test steps, hope they are understandable! Looking forward to some feedback!

vince-fugnitto

I believe that the following comment will need to be addressed:

https://github.com/eclipse-theia/theia/pull/8745/files#r523312500.

I'm however not sure about the proper approach, for example if we should merge file and directory resolvers.

packages/plugin-ext/src/main/node/resolvers/plugin-local-file-resolver.ts

fgreinacher · 2020-11-18T21:15:44Z

I believe that the following comment will need to be addressed:

https://github.com/eclipse-theia/theia/pull/8745/files#r523312500.

I'm however not sure about the proper approach, for example if we should merge file and directory resolvers.

I unified the common logic in ea032a2.

azatsarynnyy · 2020-11-19T08:37:11Z

@fgreinacher does this PR enables installing VS Code extensions by ID from Microsoft's Marketplace?

fgreinacher · 2020-11-19T08:40:08Z

@fgreinacher does this PR enables installing VS Code extensions by ID from Microsoft's Marketplace?

Nope, that is not be allowed. It just adds support for the two workflows mentioned in the "How to test" section where in the "Install by ID" workflow the data source would be the registry the VSX extension is connected to, by default OpenVSX.org.

azatsarynnyy · 2020-11-20T16:41:51Z

@fgreinacher let me know when you fix the latest comment from @vince-fugnitto and I'll merge it.
Please, don't forget to squash the commits.

fgreinacher · 2020-11-20T17:19:56Z

@vince-fugnitto Good hint, I updated the changelog.
@azatsarynnyy All done and ready for merge once CI is finished 👍🏽

vince-fugnitto

@fgreinacher please fix the failing CI: https://travis-ci.com/github/eclipse-theia/theia/jobs/444517542#L541-L543.

fgreinacher · 2020-11-20T19:00:09Z

CI does not seem to be triggered anymore. Any ideas @vince-fugnitto?

vince-fugnitto · 2020-11-20T19:02:04Z

CI does not seem to be triggered anymore. Any ideas @vince-fugnitto?

I'm not sure, an easy fix would be to perform an amend and force push.

vince-fugnitto · 2020-11-20T19:57:14Z

CI does not seem to be triggered anymore. Any ideas @vince-fugnitto?

I believe it is related to the changes by Travis: #8765 (comment).

fgreinacher · 2020-11-20T20:05:20Z

CI does not seem to be triggered anymore. Any ideas @vince-fugnitto?

I believe it is related to the changes by Travis: #8765 (comment).

😿

azatsarynnyy · 2020-11-23T10:21:37Z

CI does not seem to be triggered anymore. Any ideas @vince-fugnitto?

I'm not sure, an easy fix would be to perform an amend and force push.

@fgreinacher could you try this suggestion ^^ in order to retrigger the tests on Travis?

DucNgn · 2020-11-23T15:02:49Z

CI does not seem to be triggered anymore. Any ideas @vince-fugnitto?

I'm not sure, an easy fix would be to perform an amend and force push.

@fgreinacher could you try this suggestion ^^ in order to retrigger the tests on Travis?

We have run out of credits on Travis so the CI is temporarily disabled for all PRs at the moment.

CHANGELOG.md

packages/plugin-ext/src/main/node/resolvers/local-directory-plugin-deployer-resolver.ts

packages/plugin-ext/src/main/node/resolvers/local-file-plugin-deployer-resolver.ts

fgreinacher · 2020-12-01T19:38:11Z

Hm, one job seems to be stuck: https://github.com/eclipse-theia/theia/pull/8745/checks?check_run_id=1481816411

azatsarynnyy · 2020-12-01T19:46:17Z

Hm, one job seems to be stuck: https://github.com/eclipse-theia/theia/pull/8745/checks?check_run_id=1481816411

I've rerun it

azatsarynnyy · 2020-12-01T21:22:00Z

Hm, one job seems to be stuck: https://github.com/eclipse-theia/theia/pull/8745/checks?check_run_id=1481816411

I saw that check has failed on other PRs as well but for a different reason.
I'm not sure if can skip it to merge the PR.
cc @kittaakos @vince-fugnitto

DucNgn

Hm, one job seems to be stuck: #8745 (checks)

I saw that check has failed on other PRs as well but for a different reason.
I'm not sure if can skip it to merge the PR.
cc @kittaakos @vince-fugnitto


@theia/example-browser: Error: The number of constructor arguments in the derived class LocalDirectoryPluginDeployerResolver must be >= than the number of constructor arguments of its base class.\n    at 
/home/runner/work/theia/theia/node_modules/inversify/lib/planning/planner.js:111:27\n    at Array.forEach (<anonymous>)\n    at _createSubRequests 
(/home/runner/work/theia/theia/node_modules/inversify/lib/planning/planner.js:94:20)\n    at 
/home/runner/work/theia/theia/node_modules/inversify/lib/planning/planner.js:115:17\n    at Array.forEach (<anonymous>)\n    at 
/home/runner/work/theia/theia/node_modules/inversify/lib/planning/planner.js:114:26\n    at Array.forEach (<anonymous>)\n    at _createSubRequests 
(/home/runner/work/theia/theia/node_modules/inversify/lib/planning/planner.js:94:20)\n    at 
/home/runner/work/theia/theia/node_modules/inversify/lib/planning/planner.js:115:17\n    at Array.forEach (<anonymous>)

https://github.com/eclipse-theia/theia/pull/8745/checks?check_run_id=1482104865#step:7:24

Looking at the log, I think the CI is failing because of the changes from this PR?

packages/plugin-ext/src/main/node/resolvers/local-file-plugin-deployer-resolver.ts

… command Signed-off-by: Florian Greinacher <florian.greinacher@siemens.com>

azatsarynnyy

I've re-checked it again after the changes have been made.
Works as expected. Thanks!

fgreinacher force-pushed the feat/extension-install branch from 9741a4e to 2c1b65d Compare November 12, 2020 14:01

fgreinacher commented Nov 12, 2020

View reviewed changes

packages/plugin-ext-vscode/src/browser/plugin-vscode-commands-contribution.ts Outdated Show resolved Hide resolved

fgreinacher force-pushed the feat/extension-install branch 2 times, most recently from 63f44b7 to 097079f Compare November 13, 2020 08:42

fgreinacher marked this pull request as ready for review November 13, 2020 09:44

vince-fugnitto added vsx-registry Issues related to Open VSX Registry Integration vscode issues related to VSCode compatibility labels Nov 13, 2020

vince-fugnitto reviewed Nov 13, 2020

View reviewed changes

fgreinacher force-pushed the feat/extension-install branch 3 times, most recently from 62a341b to 1e53885 Compare November 14, 2020 00:59

fgreinacher commented Nov 14, 2020

View reviewed changes

packages/plugin-ext-vscode/src/browser/plugin-vscode-commands-contribution.ts Show resolved Hide resolved

fgreinacher commented Nov 14, 2020

View reviewed changes

packages/plugin-ext/src/main/node/resolvers/plugin-local-file-resolver.ts Outdated Show resolved Hide resolved

fgreinacher force-pushed the feat/extension-install branch from 1e53885 to e7dd47c Compare November 14, 2020 01:23

fgreinacher requested a review from vince-fugnitto November 18, 2020 08:39

vince-fugnitto reviewed Nov 18, 2020

View reviewed changes

vince-fugnitto requested review from azatsarynnyy and tolusha November 18, 2020 15:19

benoitf reviewed Nov 18, 2020

View reviewed changes

packages/plugin-ext/src/main/node/resolvers/plugin-local-file-resolver.ts Outdated Show resolved Hide resolved

benoitf reviewed Nov 18, 2020

View reviewed changes

packages/plugin-ext/src/main/node/resolvers/plugin-local-file-resolver.ts Outdated Show resolved Hide resolved

fgreinacher force-pushed the feat/extension-install branch 3 times, most recently from 0afd653 to ea032a2 Compare November 18, 2020 21:13

fgreinacher force-pushed the feat/extension-install branch 2 times, most recently from 2816f57 to 2761092 Compare November 20, 2020 17:18

vince-fugnitto reviewed Nov 20, 2020

View reviewed changes

fgreinacher force-pushed the feat/extension-install branch 2 times, most recently from 0a21765 to c372d16 Compare November 20, 2020 18:49

vince-fugnitto mentioned this pull request Nov 23, 2020

ci: replace travis with github actions #8772

Closed

fgreinacher force-pushed the feat/extension-install branch from ffc6194 to 53d3f83 Compare December 1, 2020 15:40

vince-fugnitto reviewed Dec 1, 2020

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

packages/plugin-ext/src/main/node/resolvers/local-directory-plugin-deployer-resolver.ts Outdated Show resolved Hide resolved

packages/plugin-ext/src/main/node/resolvers/local-file-plugin-deployer-resolver.ts Outdated Show resolved Hide resolved

fgreinacher force-pushed the feat/extension-install branch 3 times, most recently from 0ad933d to 15b935b Compare December 1, 2020 18:40

DucNgn reviewed Dec 1, 2020

View reviewed changes

packages/plugin-ext/src/main/node/resolvers/local-file-plugin-deployer-resolver.ts Outdated Show resolved Hide resolved

feat(vscode): add support for "workbench.extensions.installExtension"…

07504a8

… command Signed-off-by: Florian Greinacher <florian.greinacher@siemens.com>

fgreinacher force-pushed the feat/extension-install branch from 15b935b to 07504a8 Compare December 2, 2020 09:54

fgreinacher requested a review from azatsarynnyy December 2, 2020 10:30

azatsarynnyy approved these changes Dec 2, 2020

View reviewed changes

azatsarynnyy merged commit f1e37fb into eclipse-theia:master Dec 2, 2020

fgreinacher deleted the feat/extension-install branch December 2, 2020 14:21

Conversation

fgreinacher commented Nov 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What it does

How to test

Review checklist

Reminder for reviewers

Uh oh!

Uh oh!

fgreinacher commented Nov 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vince-fugnitto left a comment

Choose a reason for hiding this comment

Uh oh!

DucNgn commented Nov 13, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fgreinacher commented Nov 13, 2020

Uh oh!

Uh oh!

Uh oh!

fgreinacher commented Nov 14, 2020

Uh oh!

vince-fugnitto left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

fgreinacher commented Nov 18, 2020

Uh oh!

azatsarynnyy commented Nov 19, 2020

Uh oh!

fgreinacher commented Nov 19, 2020

Uh oh!

azatsarynnyy commented Nov 20, 2020

Uh oh!

fgreinacher commented Nov 20, 2020

Uh oh!

vince-fugnitto left a comment

Choose a reason for hiding this comment

Uh oh!

fgreinacher commented Nov 20, 2020

Uh oh!

vince-fugnitto commented Nov 20, 2020

Uh oh!

vince-fugnitto commented Nov 20, 2020

Uh oh!

fgreinacher commented Nov 20, 2020

Uh oh!

azatsarynnyy commented Nov 23, 2020

Uh oh!

DucNgn commented Nov 23, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fgreinacher commented Dec 1, 2020

Uh oh!

azatsarynnyy commented Dec 1, 2020

Uh oh!

azatsarynnyy commented Dec 1, 2020

Uh oh!

DucNgn left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

azatsarynnyy left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

fgreinacher commented Nov 12, 2020 •

edited

Loading

fgreinacher commented Nov 12, 2020 •

edited

Loading

DucNgn commented Nov 13, 2020 •

edited

Loading

DucNgn left a comment •

edited

Loading