[siw]: sync search results with editor content changes#8765
Merged
paul-marechal merged 1 commit intoeclipse-theia:masterfrom Dec 16, 2020
Merged
[siw]: sync search results with editor content changes#8765paul-marechal merged 1 commit intoeclipse-theia:masterfrom
paul-marechal merged 1 commit intoeclipse-theia:masterfrom
Conversation
vince-fugnitto
added
enhancement
DucNgn
force-pushed
the
dn/syncSearchResults
branch
2 times, most recently
from
40bfc55 to
4d9f257
Compare
vince-fugnitto
approved these changes
Nov 20, 2020
Member
vince-fugnitto
left a comment
vince-fugnitto
left a comment
There was a problem hiding this comment.
The changes work very well, there is now a sync between open editors and the search results 👍. I included minor documentation suggestions but they can be excluded if not applicable.
packages/search-in-workspace/src/browser/search-in-workspace-result-tree-widget.tsx
Outdated
Show resolved
Hide resolved
packages/search-in-workspace/src/browser/search-in-workspace-result-tree-widget.tsx
Outdated
Show resolved
Hide resolved
DucNgn
force-pushed
the
dn/syncSearchResults
branch
from
4d9f257 to
2a33431
Compare
Member
|
@eclipse-theia/core I believe we may have exhaused the travis credits as previously mentioned in the dev meeting: https://github.com/eclipse-theia/theia/wiki/Dev-Meetings#minutes-2020-11-03.
|
This was referenced Nov 20, 2020
1 task
bryanlaura736
approved these changes
Nov 25, 2020
packages/search-in-workspace/src/browser/search-in-workspace-result-tree-widget.tsx
Outdated
Show resolved
Hide resolved
DucNgn
force-pushed
the
dn/syncSearchResults
branch
from
2a33431 to
fd9d7c9
Compare
bryanlaura736
approved these changes
Dec 1, 2020
DucNgn
force-pushed
the
dn/syncSearchResults
branch
2 times, most recently
from
8d3633d to
bba0996
Compare
Contributor
Author
|
@marechal-p I rebased the PR and resolved conflicts. Can you do another round of review for this PR? |
DucNgn
force-pushed
the
dn/syncSearchResults
branch
from
bba0996 to
2367b40
Compare
DucNgn
force-pushed
the
dn/syncSearchResults
branch
from
2367b40 to
17a37ab
Compare
kittaakos
reviewed
Dec 16, 2020
packages/search-in-workspace/src/browser/search-in-workspace-result-tree-widget.tsx
Outdated
Show resolved
Hide resolved
packages/search-in-workspace/src/browser/search-in-workspace-result-tree-widget.tsx
Outdated
Show resolved
Hide resolved
packages/search-in-workspace/src/browser/search-in-workspace-result-tree-widget.tsx
Outdated
Show resolved
Hide resolved
BryanLaura
approved these changes
Dec 16, 2020
+ Add preference `search.searchOnEditorModification`. Enabling this option will make the search results in search view automatically get updated as user modify the editor. Signed-off-by: Duc Nguyen <duc.a.nguyen@ericsson.com>
DucNgn
force-pushed
the
dn/syncSearchResults
branch
from
17a37ab to
c42cf15
Compare
BryanLaura
approved these changes
Dec 16, 2020
BryanLaura
approved these changes
Dec 16, 2020
BryanLaura
approved these changes
Dec 16, 2020
BryanLaura
approved these changes
Dec 16, 2020
BryanLaura
approved these changes
Dec 16, 2020
BryanLaura
approved these changes
Dec 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
search.searchOnEditorModification. Enabling this option will make the search results in the search view automatically get updated as the user is modifying the editor.How to test
search.searchOnEditorModificationis onReview checklist
Reminder for reviewers
Signed-off-by: Duc Nguyen duc.a.nguyen@ericsson.com