Change few terminal logs from error to warning#8908
Merged
amiramw merged 1 commit intoeclipse-theia:masterfrom Jan 12, 2021
Merged
Change few terminal logs from error to warning#8908amiramw merged 1 commit intoeclipse-theia:masterfrom
amiramw merged 1 commit intoeclipse-theia:masterfrom
Conversation
Signed-off-by: Doron Nahari <doron.nahari@sap.com>
vince-fugnitto
approved these changes
Jan 4, 2021
Member
vince-fugnitto
left a comment
vince-fugnitto
left a comment
There was a problem hiding this comment.
The changes look fine to me, I don't have any objections to reducing the severity of the logs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Doron Nahari doron.nahari@sap.com
What it does
Change few "terminal gone" related logs from error to warning, because when terminal is gone, Theia starts a new terminal instead.
Review checklist
Reminder for reviewers