Skip to content

Change few terminal logs from error to warning #8908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amiramw merged 1 commit into from
Jan 12, 2021
Merged

Change few terminal logs from error to warning #8908

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/terminal/src/browser/terminal-widget-impl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,7 @@ export class TerminalWidgetImpl extends TerminalWidget implements StatefulWidget
if (IBaseTerminalServer.validateId(terminalId)) {
return terminalId;
}
this.logger.error(`Error attaching to terminal id ${id}, the terminal is most likely gone. Starting up a new terminal instead.`);
this.logger.warn(`Failed attaching to terminal id ${id}, the terminal is most likely gone. Starting up a new terminal instead.`);
if (this.kind === 'user') {
return this.createTerminal();
} else {
Expand Down
4 changes: 2 additions & 2 deletions packages/terminal/src/node/base-terminal-server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ export abstract class BaseTerminalServer implements IBaseTerminalServer {
if (term && term instanceof TerminalProcess) {
return term.id;
} else {
this.logger.error(`Couldn't attach - can't find terminal with id: ${id} `);
this.logger.warn(`Couldn't attach - can't find terminal with id: ${id} `);
return -1;
}
}
Expand Down Expand Up @@ -116,7 +116,7 @@ export abstract class BaseTerminalServer implements IBaseTerminalServer {
if (term && term instanceof TerminalProcess) {
term.resize(cols, rows);
} else {
console.error("Couldn't resize terminal " + id + ", because it doesn't exist.");
console.warn("Couldn't resize terminal " + id + ", because it doesn't exist.");
}
}

Expand Down